Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #827

Merged
merged 1 commit into from
May 25, 2022
Merged

Version Packages #827

merged 1 commit into from
May 25, 2022

Conversation

seek-oss-ci
Copy link
Contributor

@seek-oss-ci seek-oss-ci commented Apr 7, 2022

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

[email protected]

Patch Changes

  • template/private-npm-package: Use npm2 build agent queue (#843)

  • lint, test: Set timeout for Buildkite and GitHub integrations (#835)

    Transient network failures can impact annotations and autofixes. We now specify a 30 second timeout for these integration features to prevent them from hanging and indefinitely preoccupying your build agents.

  • template: Time out Buildkite test steps after 10 minutes (#842)

    Successful testing and linting should complete within this window. This timeout prevents commands from hanging and indefinitely preoccupying your Buildkite agents.

    steps:
      - label: 🧪 Test & Lint
    +   timeout_in_minutes: 10
  • cli: Make warning logs more verbose (#826)

  • template/lambda-sqs-worker: Change deployment method to direct (#868)

  • template/koa-rest-api: Use AsyncLocalStorage to track logger context (#864)

    We now employ RequestLogging.createContextStorage to thread logging context through the middleware stack of your Koa application. This enables use of a singleton logger instance instead of manually propagating Koa context and juggling rootLoggers and contextLoggers.

    Before:

    import createLogger from '@seek/logger';
    import Koa, { Context } from 'koa';
    import { RequestLogging } from 'seek-koala';
    
    const rootLogger = createLogger();
    
    const contextLogger = (ctx: Context) =>
      rootLogger.child(RequestLogging.contextFields(ctx));
    
    const app = new Koa().use((ctx) => {
      rootLogger.info('Has no context');
    
      contextLogger(ctx).info('Has context');
    });

    After:

    import createLogger from '@seek/logger';
    import Koa from 'koa';
    import { RequestLogging } from 'seek-koala';
    
    const { createContextMiddleware, mixin } =
      RequestLogging.createContextStorage();
    
    const contextMiddleware = createContextMiddleware();
    
    const logger = createLogger({ mixin });
    
    const app = new Koa().use(contextMiddleware).use((ctx) => {
      logger.info('Has context');
    });
  • template/lambda-sqs-worker: Use AsyncLocalStorage to track logger context (#871)

    We now employ this Node.js API to thread logging context through the handler of your Lambda function. This enables use of a singleton logger instance instead of manually propagating Lambda context and juggling rootLoggers and contextLoggers, and is equivalent to feat: use AsyncLocalStorage to track logger context #864.

    Before:

    import createLogger from '@seek/logger';
    import { Context } from 'aws-lambda';
    
    const rootLogger = createLogger();
    
    const contextLogger = ({ awsRequestId }: Context) =>
      rootLogger.child({ awsRequestId });
    
    const handler = async (_event: unknown, ctx: Context) => {
      rootLogger.info('Has no context');
    
      contextLogger(ctx).info('Has context');
    };

    After:

    import { AsyncLocalStorage } from 'async_hooks';
    
    import createLogger from '@seek/logger';
    import { Context } from 'aws-lambda';
    
    const loggerContext = new AsyncLocalStorage<{ awsRequestId: string }>();
    
    const logger = createLogger({
      mixin: () => loggerContext.getStore() ?? {},
    });
    
    const handler = (_event: unknown, { awsRequestId }: Context) =>
      loggerContext.run({ awsRequestId }, async () => {
        logger.info('Has context');
      });
  • template/lambda-sqs-worker*: Bump Node.js version to 16 (#862)

  • build-package, lint: Improve detection of SEEK Buildkite queues for serial execution (#829)

  • lint: Detect and autofix ESLint warnings (#844)

  • lint: Skip autofixing when ESLint reports no fixable issues (#844)

  • format, lint: Avoid unnecessary template literals (#849)

    We now automatically convert unnecessary template literals into single-quoted strings for consistency.

  • deps: Jest 28 (#856)

    This major release includes breaking changes. See the announcement post for more information.

@seek-oss-ci seek-oss-ci requested review from a team as code owners April 7, 2022 04:54
@72636c 72636c marked this pull request as draft April 7, 2022 05:03
@72636c 72636c added the dino:snooze Snooze in Review Dino label Apr 7, 2022
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 12 times, most recently from b49ae34 to f0be394 Compare April 14, 2022 05:12
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 5 times, most recently from 4692586 to b07da9f Compare April 21, 2022 02:57
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 3 times, most recently from e8c38b2 to 1cd7d1e Compare April 27, 2022 22:54
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 5 times, most recently from d928ca5 to f34a11e Compare May 10, 2022 18:23
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch from f34a11e to d9bb25e Compare May 13, 2022 01:50
@72636c

This comment was marked as resolved.

@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 4 times, most recently from ed24234 to e0e0e62 Compare May 20, 2022 06:23
@72636c 72636c mentioned this pull request May 20, 2022
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 5 times, most recently from a3c9468 to 81a2dfb Compare May 24, 2022 08:54
@72636c 72636c removed the dino:snooze Snooze in Review Dino label May 24, 2022
@72636c 72636c self-assigned this May 24, 2022
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch from 81a2dfb to e31d72f Compare May 24, 2022 17:30
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch from e31d72f to cba591c Compare May 25, 2022 03:06
@72636c 72636c marked this pull request as ready for review May 25, 2022 10:36
Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#876 is still unstable so I'm leaving it out of this release.

@72636c 72636c merged commit 4dc04da into master May 25, 2022
@72636c 72636c deleted the changeset-release/master branch May 25, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants