feat: use AsyncLocalStorage to track logger context
#864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f1ba27f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
samchungy
changed the title
AsyncLocalStorage to track contextAsyncLocalStorage to track logger context
72636c
approved these changes
May 16, 2022
There was a problem hiding this comment.
This looks excellent and it sounds like there is little performance penalty with Node.js 16: nodejs/node#34493 (comment). I think our Lambdas could similarly benefit from the same approach.
It's pretty trivial but I wonder if we should upstream something to https://github.com/seek-oss/koala to enforce this pattern.
Co-authored-by: Ryan Ling <[email protected]>
|
Going to wait for the koala PR to go through before changing this to use that implementation. |
72636c
added a commit
that referenced
this pull request
May 21, 2022
Co-authored-by: Ryan Ling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a little radical but overall improves the DX and allows users to not need to worry about passing a context object around and/or a context logger around the codebase.
Some local testing confirms
x-request-idis still present:Performance hit of ~1.75% according to this which is negligible
nodejs/node#34493 (comment)