Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve autofixing #844

Merged
merged 2 commits into from
Apr 16, 2022
Merged

Improve autofixing #844

merged 2 commits into from
Apr 16, 2022

Conversation

72636c
Copy link
Member

@72636c 72636c commented Apr 15, 2022

  1. Skip when ESLint reports no fixable issues
  2. Detect ESLint warnings instead of just errors

1. Skip when ESLint reports no fixable issues
2. Detect ESLint warnings instead of just errors
@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2022

🦋 Changeset detected

Latest commit: 310a2e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -68,14 +79,19 @@ export const autofix = async (input: Pick<Input, 'debug'>): Promise<void> => {
return;
}

// Naively try to autofix issues as we can't tell from ESLint output.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brain must've 404ed when I wrote this

@72636c 72636c marked this pull request as ready for review April 15, 2022 07:19
@72636c 72636c requested review from a team as code owners April 15, 2022 07:19
@72636c 72636c merged commit 8456938 into master Apr 16, 2022
@72636c 72636c deleted the improve-autofixing branch April 16, 2022 01:36
@seek-oss-ci seek-oss-ci mentioned this pull request Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants