Bump up sqs worker templates to Node 16 #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5b66395 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Truly a momentous occasion |
samchungy
commented
May 11, 2022
| architecture: arm64 | ||
| stackName: ${self:service} | ||
| stage: ${env:ENVIRONMENT} | ||
| versionFunctions: true |
There was a problem hiding this comment.
This is by default true. https://www.serverless.com/framework/docs/providers/aws/guide/functions
|
Can we upgrade the CDK template too? |
Awaiting this to be released :( aws/aws-cdk#20261. Guess this PR can wait a little bit more |
samchungy
commented
May 13, 2022
| @@ -22,11 +26,5 @@ | |||
| "test": "skuba test", | |||
| "test:ci": "skuba test --coverage", | |||
| "test:watch": "skuba test --watch" | |||
| }, | |||
| "skuba": { | |||
There was a problem hiding this comment.
Aligning with other templates
samchungy
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's finally here......