Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing a dataset from disk #6615

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Fix importing a dataset from disk #6615

merged 6 commits into from
Nov 9, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Nov 7, 2022

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • remove the datasource-properties.json for an existing dataset and reload the list in the dashboard
  • try to import the dataset by using the inferred values from wk

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Nov 7, 2022
@fm3
Copy link
Member

fm3 commented Nov 7, 2022

I think you branched off of folders – could you cherry pick the relevant commit here? 😇

@philippotto
Copy link
Member Author

I think you branched off of folders – could you cherry pick the relevant commit here? innocent

Argh, good catch. I didn't branch wrong, though. Instead, I pulled the folders branch into this branch 🤦

Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected using the testing instructions 👍

Maybe unrelated, but I noticed that there is no field to enter the largestSegmentId for the dataset I tested this with (ROI2017_wkw), although it has a segmentation layer. Is this expected or a regression (from another PR)?

…orting a dataset from disk without pre-existing datasource-properties.json
@philippotto
Copy link
Member Author

Maybe unrelated, but I noticed that there is no field to enter the largestSegmentId for the dataset I tested this with (ROI2017_wkw), although it has a segmentation layer. Is this expected or a regression (from another PR)?

Good catch! I think, it's a regression from the same PR. I fixed it now :)

Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@philippotto philippotto enabled auto-merge (squash) November 9, 2022 10:21
@philippotto philippotto merged commit 6758b82 into master Nov 9, 2022
@philippotto philippotto deleted the fix-import-flow branch November 9, 2022 10:25
philippotto added a commit that referenced this pull request Nov 10, 2022
* fix importing a dataset that hasn't got a datasource-properties.json yet

* remove unnecessary import

* update changelog

* fix missing largest segment id input for segmentation layers when importing a dataset from disk without pre-existing datasource-properties.json

Co-authored-by: Florian M <[email protected]>
@philippotto philippotto mentioned this pull request Nov 10, 2022
3 tasks
hotzenklotz added a commit that referenced this pull request Nov 11, 2022
…cing

* 'master' of github.com:scalableminds/webknossos:
  Fix parsing failure during import of ngff zarr datasets with translation transforms (#6621)
  Fix rerender after each layer name keypress in dataset import view (#6628)
  Create a layer for each channel of NGFF-Zarr datasets (#6609)
  Fix screenshot tests (#6623)
  Fix importing a dataset from disk (#6615)
  Allow deleting annotation layers (#6593)
  Rephrased Error Messages (#6616)
philippotto added a commit that referenced this pull request Nov 15, 2022
* Fix importing a dataset from disk (#6615)

* fix importing a dataset that hasn't got a datasource-properties.json yet

* remove unnecessary import

* update changelog

* fix missing largest segment id input for segmentation layers when importing a dataset from disk without pre-existing datasource-properties.json

Co-authored-by: Florian M <[email protected]>

* remove superfluous comment which slipped during resolving merge conflict

* release 22.11.2

Co-authored-by: Florian M <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants