-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix importing a dataset from disk #6615
Conversation
I think you branched off of folders – could you cherry pick the relevant commit here? 😇 |
4b13135
to
a362e07
Compare
Argh, good catch. I didn't branch wrong, though. Instead, I pulled the folders branch into this branch 🤦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected using the testing instructions 👍
Maybe unrelated, but I noticed that there is no field to enter the largestSegmentId
for the dataset I tested this with (ROI2017_wkw), although it has a segmentation layer. Is this expected or a regression (from another PR)?
…orting a dataset from disk without pre-existing datasource-properties.json
Good catch! I think, it's a regression from the same PR. I fixed it now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* fix importing a dataset that hasn't got a datasource-properties.json yet * remove unnecessary import * update changelog * fix missing largest segment id input for segmentation layers when importing a dataset from disk without pre-existing datasource-properties.json Co-authored-by: Florian M <[email protected]>
…cing * 'master' of github.com:scalableminds/webknossos: Fix parsing failure during import of ngff zarr datasets with translation transforms (#6621) Fix rerender after each layer name keypress in dataset import view (#6628) Create a layer for each channel of NGFF-Zarr datasets (#6609) Fix screenshot tests (#6623) Fix importing a dataset from disk (#6615) Allow deleting annotation layers (#6593) Rephrased Error Messages (#6616)
* Fix importing a dataset from disk (#6615) * fix importing a dataset that hasn't got a datasource-properties.json yet * remove unnecessary import * update changelog * fix missing largest segment id input for segmentation layers when importing a dataset from disk without pre-existing datasource-properties.json Co-authored-by: Florian M <[email protected]> * remove superfluous comment which slipped during resolving merge conflict * release 22.11.2 Co-authored-by: Florian M <[email protected]>
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)