-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Zarr Import UI (and general editing of datasets) #6485
Conversation
frontend/javascripts/dashboard/dataset/dataset_settings_data_tab.tsx
Outdated
Show resolved
Hide resolved
…ere's proper validation for that now)
@fm3 I think the initial name is coming from the back-end, right? defaulting to an empty string sounds like a good solution for now (definitely, better than a poor guess, I'd say). |
…und antd useWatch issue
@fm3 I fixed this in the front-end now. I think it's fair to say that the backend only infers what's on disk. So, adding existing zarr layers to the inferred datasource makes (some) sense to me. Let me know in case you disagree 🤙 |
Yes, makes sense to me 👍
correct
ok I’ll include that change in #6520 to avoid merge conflicts, that pr should be merged soon |
@hotzenklotz Thanks for the thorough testing. I debugged and integrated your ideas as best as possible. Please test again (the new dev instance is already deployed).
This is the only thing I didn't do. The form handling with antd is quite error-prone. I'd defer this feature to another iteration (maybe in combination to when the dataset management topic is tackled) to not drag this PR any longer. |
I re-tested and LGTM. Ready to merge :-) |
I need your official acceptance to merge this PR :) |
…ebar_button * 'master' of github.com:scalableminds/webknossos: added more usage shortcuts to status bar (#6549) Look up annotation dataset by tracing id instead of (broken) organizationName field (#6548) Add links to resource creation pages (#6513) Improve Zarr Import UI (and general editing of datasets) (#6485) Remove unused dataSetName and organizationName property of protobuf objects (#6559) WIP: Added manual task assignment (#6551) Fix zarr private links for volume tracings and some minor improvements to private links UI (#6541) Fix stack overflow in compactMovedNodesAndEdges (#6557)
…ect_spinner * 'master' of github.com:scalableminds/webknossos: added more usage shortcuts to status bar (#6549) Look up annotation dataset by tracing id instead of (broken) organizationName field (#6548) Add links to resource creation pages (#6513) Improve Zarr Import UI (and general editing of datasets) (#6485) Remove unused dataSetName and organizationName property of protobuf objects (#6559) WIP: Added manual task assignment (#6551) Fix zarr private links for volume tracings and some minor improvements to private links UI (#6541) Fix stack overflow in compactMovedNodesAndEdges (#6557)
…ault_volume_layer * 'master' of github.com:scalableminds/webknossos: (21 commits) adds ETA calculation to voxelytics tasks (#6564) update immutability-helper package to v3.1.1 with TS support (#6565) [Skeletons] Allow deletion of root group (#6553) fix disappearing sidebar button (#6555) Enable "What's new" in navbar for everybody (#6563) Highlight Menu in Navbar Menu (#6558) refactor Select loading spinner property (#6556) Reload histogram when reloading layer (#6537) added more usage shortcuts to status bar (#6549) Look up annotation dataset by tracing id instead of (broken) organizationName field (#6548) Add links to resource creation pages (#6513) Improve Zarr Import UI (and general editing of datasets) (#6485) Remove unused dataSetName and organizationName property of protobuf objects (#6559) WIP: Added manual task assignment (#6551) Fix zarr private links for volume tracings and some minor improvements to private links UI (#6541) Fix stack overflow in compactMovedNodesAndEdges (#6557) Add backspace keyboard shortcut to delete active node (#6554) fix scaling in new meshfile rendering (#6552) Added more filters and sorting options to Projects list (#6550) fix double occurance of "ago" in VX progress times (#6535) ...
URL of deployed dev instance (used for testing):
Steps to test:
https://data-humerus.webknossos.org/data/zarr/scalable_minds/l4dense_motta_et_al_demo/segmentation
)Issues:
(Please delete unneeded items, merge only when none are left open)