Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rerender after each layer name keypress in dataset import view #6628

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Fix rerender after each layer name keypress in dataset import view #6628

merged 2 commits into from
Nov 10, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Nov 10, 2022

URL of deployed dev instance (used for testing):

Steps to test:

  • Import a remote zarr dataset
  • In the edit view, change a layer name
  • typing there should not trigger re-render after each keypress, causing the text field to lose focus

Issues:

@fm3 fm3 self-assigned this Nov 10, 2022
hotzenklotz
hotzenklotz approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fm3 fm3 enabled auto-merge (squash) November 10, 2022 12:01
@fm3 fm3 merged commit b18635a into master Nov 10, 2022
@fm3 fm3 deleted the edit-view-fix-rerender branch November 10, 2022 12:18
hotzenklotz added a commit that referenced this pull request Nov 11, 2022
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into pri…
cb094d4 
…cing

* 'master' of github.com:scalableminds/webknossos:
  Fix parsing failure during import of ngff zarr datasets with translation transforms (#6621)
  Fix rerender after each layer name keypress in dataset import view (#6628)
  Create a layer for each channel of NGFF-Zarr datasets (#6609)
  Fix screenshot tests (#6623)
  Fix importing a dataset from disk (#6615)
  Allow deleting annotation layers (#6593)
  Rephrased Error Messages (#6616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotzenklotz hotzenklotz hotzenklotz approved these changes

Assignees

@fm3 fm3

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataset Edit View: Typing in Layer Name field triggers rerender, input loses focus
2 participants
@fm3 @hotzenklotz