Fix screenshot tests #6623
Fix screenshot tests #6623
Conversation
…ataset no longer appears and meshes are now smoothed, also only persist a diff image if the pixel difference was significant (and the test failed)
|
@philippotto This was actually the fix 🎉 I updated some more screenshots, because the error toast that was partly visible in some of them no longer appears and because the meshes are now smoothed. If all screenshot tests except for the connectome one succeed this should be ready to go (the connectome viewer is not enabled for this branch) once the temporary changes are reverted. |
|
Screenshot tests look good: https://app.circleci.com/pipelines/github/scalableminds/webknossos/8868/workflows/bc5ac41a-3c51-47a1-9d88-3002de4e6cea/jobs/20233/steps (see my last comment for why the connectome dataset fails) |
|
I hope it's alright if I merge this PR already. From my side, it's looking very good :) Then, we can have a green nightly tonight hopefully 🤞 Otherwise, a follow-up should do it. |
…cing * 'master' of github.com:scalableminds/webknossos: Fix parsing failure during import of ngff zarr datasets with translation transforms (#6621) Fix rerender after each layer name keypress in dataset import view (#6628) Create a layer for each channel of NGFF-Zarr datasets (#6609) Fix screenshot tests (#6623) Fix importing a dataset from disk (#6615) Allow deleting annotation layers (#6593) Rephrased Error Messages (#6616)
By always initializing mapping color texture with EMPTY_KEY. Otherwise, the content of the texture is undefined which led to issues during our automated nightly tests (presumably, because the texture contained lots of 1s, segment 1 was not rendered correctly).
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)