Task: CombinatorialPolyhedron: replace attributes by methods, make names more consistent with Polyhedron

[kliem]

This ticket gathers tickets related to the `CombinatorialPolyhedron' class.

The goal is to make this class consistent with the base class Polyhedron_base.

• CombinatorialPolyhedron: edge_graph -> vertex_graph #28603: edge_graph -> vertex_graph.
• CombinatorialPolyhedron: ridge_graph -> facet_graph #28604: ridge_graph -> facet_graph.
• CombinatorialPolyhedron: replace attributes by methods #28605: Replace attributes in CombinatorialPolyhedron by methods, such that they can potentially be lazily evaluated.
  This is motivated by Make CombinatorialPolyhedron a base class for polyhedra/lattice polytopes/cones #10777.
• CombinatorialPolyhedron: unbounded -> is_bounded #28606: unbounded(self) -> is_bounded(self).
• CombinatorialPolyhedron: make f_vector a vector #28607: Make f_vector a vector.
• CombinatorialPolyhedron: attributes, H -> facet_names; V -> Vrep #28613: Replace V and H by more meaningful attributes/methods.
• CombinatorialPolyhedron: length_* to n_* #28614: length_* -> n_*.
• CombinatorialFace: replace Vrepr() and Hrepr() by more consistent names #28616: Replace Vrepr() and Hrepr by more consistent methods in CombinatorialFace.
• CombinatorialPolyhedron: abbrevations Hrepr -> Hrep etc. #28608: repr -> rep when abbreviating.
• CombinatorialPolyhedron: Remove empty folder #28757: Remove empty folder
• Make dim and alias for dimension in combinatorial polyhedron #29110: Make dim and alias for dimension in combinatorial polyhedron
• CombinatorialPolyhedron: bit_repr_ -> bit_rep_ #29242: CombinatorialPolyhedron: bit_repr_ -> bit_rep_

Some of the tickets also take care of minor bug fixes or typos.

CC: @jplab @tscrim @videlec @LaisRast @fchapoton

Component: geometry

Author: Jonathan Kliem

Reviewer: Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/28280

[kliem]

comment:1

Some attributes like bitrep_vertices might have been an unfortunate choice:

As they are accessed by other classes, I'm forced to compute e.g. bitrep_vertices on initialization. If CombinatorialPolyhedron was ever to be a parent of Polyhedron_base (see #10777), this would force a polyhedron to compute the incidence matrix right away.

From my understanding, the decorator @lazy_attribute is not available for extension types directly. I'm thinking of changing those attributes to methods, such that there is a method bitrep_facets and an attribute _bitrep_facets. This way one can later change this to be lazily evaluated.

Any thoughts?

[kliem]

Branch: public/28280

[kliem]

Dependencies: #27987

[kliem]

Author: Jonathan Kliem

[kliem]

Commit: 0aed9fd

[kliem]

New commits:

d6d663a	combinatorial polyhedron uses far face as a bug fix
14d17a8	added doctest reporting the bug fix
806a217	correct link to trac ticket, if unbounded is False -> if not unbounded
9194627	replace attributes by methods
0aed9fd	removed empty folder being created in source

[sagetrac-git]

Changed commit from 0aed9fd to 2fc4fe0

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d597ed3	replace attributes by methods
2fc4fe0	removed empty folder being created in source