CombinatorialPolyhedron: length_* to n_*

[kliem]

To make CombinatorialPolyhedron more consistent with Polyhedron we change the following names.

• length_Hrepr -> n_Hrepresentation
• length_Vrepr -> n_Vrepresentation

In FaceIterator:

• length_atom_repr -> n_atom_rep (note that CombinatorialPolyhedron: abbrevations Hrepr -> Hrep etc. #28608 changes repr to rep)

In CombinatorialFace:

• length_Vrepr -> n_ambient_Vrepresentation
• length_Hrepr -> n_ambient_Hrepresentation
  As both methods are public we keep the old methods with deprecation warnings.

As a follow up in #28615 we need to fix the alignment in src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd. Fixing it in this ticket would lead to merge conflicts and as its trivial, we can easily do it later.

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: 2ad0ec0

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/28614

[kliem]

Description changed:

--- 
+++ 
@@ -8,3 +8,5 @@
 
 In `CombinatorialFace`:
 `length_Vrepresentation` -> `n_ambient_Vrepresentation`
+
+As a follow up we need to fix the alignment in `src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd`. Fixing it in this ticket would lead to merge conflicts and as its trivial, we can easily do it later.

[kliem]

Description changed:

--- 
+++ 
@@ -1,12 +1,12 @@
 To make `CombinatorialPolyhedron` more consistent with `Polyhedron` we change the following names.
 
-`length_Hrepr` -> `n_Hrepresentation`
-`length_Vrepr` -> `n_Vrepresentation`
+- `length_Hrepr` -> `n_Hrepresentation`
+- `length_Vrepr` -> `n_Vrepresentation`
 
 In `FaceIterator`:
-`length_atom_repr` -> `n_atom_rep` (note that #28608 changes `repr` to `rep`)
+- `length_atom_repr` -> `n_atom_rep` (note that #28608 changes `repr` to `rep`)
 
 In `CombinatorialFace`:
-`length_Vrepresentation` -> `n_ambient_Vrepresentation`
+- `length_Vrepresentation` -> `n_ambient_Vrepresentation`
 
 As a follow up we need to fix the alignment in `src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd`. Fixing it in this ticket would lead to merge conflicts and as its trivial, we can easily do it later.

[kliem]

Description changed:

--- 
+++ 
@@ -7,6 +7,6 @@
 - `length_atom_repr` -> `n_atom_rep` (note that #28608 changes `repr` to `rep`)
 
 In `CombinatorialFace`:
-- `length_Vrepresentation` -> `n_ambient_Vrepresentation`
+- `length_Vrepr` -> `n_ambient_Vrepresentation`
 
 As a follow up we need to fix the alignment in `src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd`. Fixing it in this ticket would lead to merge conflicts and as its trivial, we can easily do it later.

[kliem]

Commit: 2bddb97

[kliem]

New commits:

d597ed3	replace attributes by methods
2fc4fe0	removed empty folder being created in source
37592f9	replace attributes by methods; remove empty folder from source
e865f9d	removed attribute Vinv, as its not being used
84ef31b	added docstrings to the new methods
588afa4	removed method for Vinv
2bddb97	length_* -> n_

[kliem]

Branch: public/28614

[sagetrac-git]

Changed commit from 2bddb97 to c030651

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c030651

deprecation warnings; n_Vrepresentation -> n_ambient_Vrepresentation in CombinatorialFace

[kliem]

New commits:

c030651

deprecation warnings; n_Vrepresentation -> n_ambient_Vrepresentation in CombinatorialFace

[kliem]

Changed keywords from none to polytopes, combinatorial polyhedron

[kliem]

Description changed:

--- 
+++ 
@@ -8,5 +8,7 @@
 
 In `CombinatorialFace`:
 - `length_Vrepr` -> `n_ambient_Vrepresentation`
+- `length_Hrepr` -> `n_ambient_Hrepresentation`
+As both methods are public we keep the old methods with deprecation warnings.
 
 As a follow up we need to fix the alignment in `src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd`. Fixing it in this ticket would lead to merge conflicts and as its trivial, we can easily do it later.