CombinatorialFace: replace Vrepr() and Hrepr() by more consistent names

[kliem]

In order to make CombinatorialFace be more consistent with PolyhedronFace we make the following changes:

• face.Hrepr(True) -> face.ambient_Hrepresentation(),
• face.Hrepr(False) -> face.ambient_H_indices(),
• face.Vrepr(True) -> face.ambient_Vrepresentation(),
• face.Vrepr(False) -> face.ambient_V_indices().

We keep the old methods with deprecation warnings.

CC: @jplab @LaisRast

Component: geometry

Author: Jonathan Kliem

Branch/Commit: 184784c

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/28616

[kliem]

Description changed:

--- 
+++ 
@@ -1,8 +1,8 @@
 In order to make `CombinatorialFace` be more consistent with `PolyhedronFace` we make the following changes:
 
-- face.Hrepr(True) -> face.ambient_Hrepresentation(),
-- face.Hrepr(False) -> face.ambient_H_indices(),
-- face.Vrepr(True) -> face.ambient_Vrepresentation(),
-- face.Vrepr(False) -> face.ambient_V_indices().
+- `face.Hrepr(True)` -> `face.ambient_Hrepresentation()`,
+- `face.Hrepr(False)` -> `face.ambient_H_indices()`,
+- `face.Vrepr(True)` -> `face.ambient_Vrepresentation()`,
+- `face.Vrepr(False)` -> `face.ambient_V_indices()`.
 
 We keep the old methods with deprecation warnings.

[kliem]

Dependencies: #28613

[kliem]

Branch: public/28616

[kliem]

New commits:

d597ed3	replace attributes by methods
2fc4fe0	removed empty folder being created in source
37592f9	replace attributes by methods; remove empty folder from source
e865f9d	removed attribute Vinv, as its not being used
84ef31b	added docstrings to the new methods
588afa4	removed method for Vinv
a366387	H -> facet_names; V -> Vrep
cf8dc4c	Vrepr(True) -> ambient_Vrepresentation(); Vrepr(False) -> ambient_V_indices
608ead0	Hrepr(True) -> ambient_Hrepresentation(); Hrepr(False) -> ambient_H_indices

[kliem]

Commit: 608ead0

[sagetrac-git]

Changed commit from 608ead0 to 531ae53

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

531ae53

changed stacklevel to 3, so deprecation warning shows during normal usage

[kliem]

comment:5

Waiting on the depend tickets.