CombinatorialPolyhedron: replace attributes by methods

[kliem]

Replace attributes in CombinatorialPolyhedron by methods, such that they can potentially be lazily evaluated.

More precisely we replace an attribute by a private attribute (with leading _) and add a method without leading _. E.g. the attribute far_face_tuple is replaced by _far_face_tuple and we add a method far_face_tuple(self). Thus we gain flexibility in the sense that those attributes must not be set on initialization.

This is motivated by #10777.

We remove the attribute Vinv completely, as it is not being used.

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: d4b3163

Reviewer: Laith Rastanawi, Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/28605

[kliem]

Branch: public/28605

[kliem]

New commits:

d597ed3	replace attributes by methods
2fc4fe0	removed empty folder being created in source
37592f9	replace attributes by methods; remove empty folder from source

[kliem]

Commit: 37592f9

[kliem]

Changed keywords from none to polytopes, combinatorial polyhedron

[kliem]

Description changed:

--- 
+++ 
@@ -3,3 +3,5 @@
 This is motivated by #10777.
 
 We also delete `.cc` in the module name of `bit_vector_operations`. The `.cc` lead to an empty folder in the source directory. Without this, the folder does not reappear.
+
+We remove the attribute `Vinv` completely, as there it is not being used at all.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e865f9d	removed attribute Vinv, as its not being used
84ef31b	added docstrings to the new methods
588afa4	removed method for Vinv

[sagetrac-git]

Changed commit from 37592f9 to 588afa4

[kliem]

comment:6

Adding #28625 as I'm using attributes in that ticket.

At moment I think #28625 might be finished before this here, but we can always revers dependencies and change it there.

[kliem]

Dependencies: #28625

[LaisRast]

Reviewer: Laith Rastanawi