Rollup of 4 pull requests - #162396
Closed
jhpratt wants to merge 10 commits into
Closed
Conversation
ARMv8-M Baseline targets support CAS operations, but the atomic module docs incorrectly list them as load and store-only. Limit that restriction to ARMv6-M and include thumbv8m.base-* among the targets with full CAS support.
Since `reason` already has a span itself
…bank Use `reason` for tracked item diagnostics from `cfg_select!` This is a follow-up of rust-lang#157218 (comment) I recommend reviewing commit by commit, each commit passes uitests. r? @estebank
…omic-cas, r=JohnTitor docs(core): correct ARMv8-M Baseline atomic CAS support ARMv8-M Baseline targets support CAS operations, but the atomic module docs incorrectly list them as load and store-only. The incorrect ARMv8-M Baseline comment was introduced in rust-lang#149241 while updating the atomic portability notes for ARMv4T/ARMv5TE. Limit that restriction to ARMv6-M and include `thumbv8m.base-*` among the targets with full CAS support. @rustbot label +A-docs +A-atomic +O-Arm +T-libs
Add a hint for using `nolimit` to the limiting error message So people know they can get around it :) I think the current wording is fine, if you'd like the message to be a bit scarier by adding "If really needed, ", lmk
remove EnumSizeOpt This was landed years ago but has never been enabled due to odd issues that came up when merging it. The issues never got investigated (or at least, not with any conclusions). The author of the pass [said](rust-lang#154413 (comment)) they don't have time to work on it and recommend removing it. So... let's do that. r? @saethlin Fixes rust-lang#154413
rustbot
added
A-attributes
Member
Author
|
@bors r+ p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit c51c3dd with merge cbe74a3... Workflow: https://github.com/rust-lang/rust/actions/runs/34080338347 |
Member
Author
|
stalled; closing in favor of larger rollup |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. Auto build was cancelled due to the PR being closed. Cancelled workflows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
reasonfor tracked item diagnostics fromcfg_select!#162367 (Usereasonfor tracked item diagnostics fromcfg_select!)nolimitto the limiting error message #162383 (Add a hint for usingnolimitto the limiting error message)r? @ghost
Create a similar rollup