Rollup of 8 pull requests#154855
Closed
JonathanBrouwer wants to merge 27 commits intorust-lang:mainfrom
Closed
Conversation
By not pushing any crates to each_linked_rlib_for_lto when no cross-crate LTO is used, we can avoid special cases elsewhere.
It is still not entirely correct I think, but much closer to the current way things are done.
Forward discriminant-related queries through `ty::UnsafeBinder` to the erased inner type, matching the existing layout behavior.
Scalable vector types in `core_arch` are cfg'd for aarch64 and for rustdoc, which can successfully document these types given any `--target` (`core_arch` CI uses `i686-unknown-linux-gnu`) - this shouldn't trigger the "scalable vectors not supported on arch" error.
Various LTO cleanups * Move some special casing of thin local LTO into a single location. * Move lto_import_only_modules handling for fat LTO earlier. There is no reason to keep it separate until right before pass the LTO modules to the codegen backend. For thin LTO this introduces `ThinLtoInput` to correctly handle incr comp caching. * Remove the `Linker` type from cg_llvm. It previously helped deduplicate code for `-Zcombine-cgus`, but that flag no longer exists. Part of rust-lang/compiler-team#908
…fter-visibility, r=TaKO8Ki Suggest similar keyword when visibility is not followed by an item Fixes rust-lang#153353. I would appreciate feedback on the following: - I inlined [`find_similar_kw`](https://github.com/rust-lang/rust/blob/cd14b73b4a41542d921f59e362a5b5005fa4f2ef/compiler/rustc_parse/src/parser/diagnostics.rs#L218-L224) instead of changing its visibility to `pub(super)`. I am happy to switch if it is preferred; - I didn't add a comment to the new test. Although the rustc-dev-guide specifies that a [comment should be added](https://rustc-dev-guide.rust-lang.org/tests/adding.html#comment-explaining-what-the-test-is-about) to every new test, this is not common in `tests/ui/parser/misspelled_keywords/` and the test seems self-explanatory. Let me know if you would like me to add a comment; Thank you in advance for your time and input!
…rn-assignment-help, r=Kivooeo Fix pattern assignment suggestions for uninitialized bindings Fixes rust-lang#145564
…iminant, r=jdonszelmann Fix ICE in unsafe binder discriminant helpers Forward discriminant-related helpers through `ty::UnsafeBinder` to the erased inner type, matching the existing layout behavior. Tracking issue: rust-lang#130516 Closes rust-lang#154424
…message, r=jdonszelmann fix(lints): Improve `ill_formed_attribute_input` with better help message Add a better help message to `ill_formed_attribute_input` for the cases where it matches the usage of `#![allow]`. For further details see rust-lang#154667 closes rust-lang#154667 cc: @Zalathar
…onszelmann Post-attribute ports cleanup pt. 1 r? @jdonszelmann This cleans up some checks I could find were for non-parsed attributes, and works towards removing BUILTIN_ATTRIBUTES All commits do one thing and every commit passes tests, so best reviewed commit by commit
…Mark-Simulacrum Promote `char::is_case_ignorable` from perma-unstable to unstable (Take two of rust-lang#154658, which was closed when GitHub Codespaces somehow managed to squash the entire commit history of rust-lang/rust into one commit) This function is currently used in the implementation of `str::to_lowercase()`. There is no reason to restrict it to the stdlib, though. Reimplementations of string casing for types other than `str` -> `String` shouldn't need to waste space with a duplicate copy of this table. @rustbot label A-unicode T-libs-api r? @Mark-Simulacrum
…, r=JonathanBrouwer ast_validation: scalable vectors okay for rustdoc Scalable vector types in `core_arch` are cfg'd for aarch64 and for rustdoc, which can successfully document these types given any `--target` (`core_arch` CI uses `i686-unknown-linux-gnu`) - this shouldn't trigger the "scalable vectors not supported on arch" error. This fixes the CI failure in rust-lang/stdarch#2071.
rustbot
added
A-attributes
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 322e501 with merge fce43f0... Workflow: https://github.com/rust-lang/rust/actions/runs/24007095084 |
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2026
…uwer Rollup of 8 pull requests Successful merges: - #153440 (Various LTO cleanups) - #154561 (Suggest similar keyword when visibility is not followed by an item) - #154657 (Fix pattern assignment suggestions for uninitialized bindings) - #154717 (Fix ICE in unsafe binder discriminant helpers) - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message) - #154808 (Post-attribute ports cleanup pt. 1) - #154849 (Promote `char::is_case_ignorable` from perma-unstable to unstable) - #154850 (ast_validation: scalable vectors okay for rustdoc)
Contributor
Author
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #154855. |
Contributor
|
⌛ Testing commit 322e501 with merge d004467... Workflow: https://github.com/rust-lang/rust/actions/runs/24011608910 |
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2026
…uwer Rollup of 8 pull requests Successful merges: - #153440 (Various LTO cleanups) - #154561 (Suggest similar keyword when visibility is not followed by an item) - #154657 (Fix pattern assignment suggestions for uninitialized bindings) - #154717 (Fix ICE in unsafe binder discriminant helpers) - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message) - #154808 (Post-attribute ports cleanup pt. 1) - #154849 (Promote `char::is_case_ignorable` from perma-unstable to unstable) - #154850 (ast_validation: scalable vectors okay for rustdoc)
Member
|
At 5h20m with the same runner pending, I think it's safe to assume it's stalled. Yielding to a separate rollup rather than waiting another 40m for this to presumably time out. @bors yield |
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #154855. |
Contributor
|
⌛ Testing commit 322e501 with merge c1cf0b7... Workflow: https://github.com/rust-lang/rust/actions/runs/24017573810 |
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2026
…uwer Rollup of 8 pull requests Successful merges: - #153440 (Various LTO cleanups) - #154561 (Suggest similar keyword when visibility is not followed by an item) - #154657 (Fix pattern assignment suggestions for uninitialized bindings) - #154717 (Fix ICE in unsafe binder discriminant helpers) - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message) - #154808 (Post-attribute ports cleanup pt. 1) - #154849 (Promote `char::is_case_ignorable` from perma-unstable to unstable) - #154850 (ast_validation: scalable vectors okay for rustdoc)
Member
|
Ah right. This is at the top of the list… @bors p=4 yield |
Member
|
@bors yield |
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #154862. |
Contributor
Author
|
Started 3 try jobs in the 3 prs of #154845 |
rust-bors
bot
added
the
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
rust-bors
bot
removed
the
S-waiting-on-bors
Contributor
Author
|
Problem seems to be in this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ill_formed_attribute_inputwith better help message #154722 (fix(lints): Improveill_formed_attribute_inputwith better help message)char::is_case_ignorablefrom perma-unstable to unstable #154849 (Promotechar::is_case_ignorablefrom perma-unstable to unstable)r? @ghost
Create a similar rollup