Skip to content

Promote char::is_case_ignorable from perma-unstable to unstable#154658

Closed
Jules-Bertholet wants to merge 1 commit intorust-lang:mainfrom
Jules-Bertholet:case-ignorable
Closed

Promote char::is_case_ignorable from perma-unstable to unstable#154658
Jules-Bertholet wants to merge 1 commit intorust-lang:mainfrom
Jules-Bertholet:case-ignorable

Conversation

@Jules-Bertholet
Copy link
Copy Markdown
Contributor

@Jules-Bertholet Jules-Bertholet commented Apr 1, 2026 •
edited
Loading

This function is currently used in the implementation of str::to_lowercase(). There is no reason to restrict it to the stdlib, though. Reimplementations of string casing for types other than String shouldn't need to waste space with a duplicate copy of this table.

@rustbot label A-unicode T-libs-api

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 1, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 1, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, scottmcm

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-Unicode Area: Unicode labels Apr 1, 2026
Mark-Simulacrum
Mark-Simulacrum requested changes Apr 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Mark-Simulacrum Mark-Simulacrum left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with a tracking issue filed and added

(I don't think we need an ACP for this, given the impl already exists and must exist for to_lowercase. If we decide not to stabilize at some point it can go back to being internal).

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 4, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Jules-Bertholet Jules-Bertholet mentioned this pull request Apr 5, 2026
Open
3 tasks
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 5, 2026
@Jules-Bertholet
Copy link
Copy Markdown
Contributor Author

Jules-Bertholet commented Apr 5, 2026

Sorry, Git accident

@Jules-Bertholet Jules-Bertholet mentioned this pull request Apr 5, 2026
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 5, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154849 - Jules-Bertholet:case-ignorable, r=…
5bc663b 
…Mark-Simulacrum

Promote `char::is_case_ignorable` from perma-unstable to unstable

(Take two of rust-lang#154658, which was closed when GitHub Codespaces somehow managed to squash the entire commit history of rust-lang/rust into one commit)

This function is currently used in the implementation of `str::to_lowercase()`. There is no reason to restrict it to the stdlib, though. Reimplementations of string casing for types other than `str` -> `String` shouldn't need to waste space with a duplicate copy of this table.

@rustbot label A-unicode T-libs-api

r? @Mark-Simulacrum
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154849 - Jules-Bertholet:case-ignorable, r=…
7a83ebc 
…Mark-Simulacrum

Promote `char::is_case_ignorable` from perma-unstable to unstable

(Take two of rust-lang#154658, which was closed when GitHub Codespaces somehow managed to squash the entire commit history of rust-lang/rust into one commit)

This function is currently used in the implementation of `str::to_lowercase()`. There is no reason to restrict it to the stdlib, though. Reimplementations of string casing for types other than `str` -> `String` shouldn't need to waste space with a duplicate copy of this table.

@rustbot label A-unicode T-libs-api

r? @Mark-Simulacrum
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154849 - Jules-Bertholet:case-ignorable, r=…
6bf2ce0 
…Mark-Simulacrum

Promote `char::is_case_ignorable` from perma-unstable to unstable

(Take two of rust-lang#154658, which was closed when GitHub Codespaces somehow managed to squash the entire commit history of rust-lang/rust into one commit)

This function is currently used in the implementation of `str::to_lowercase()`. There is no reason to restrict it to the stdlib, though. Reimplementations of string casing for types other than `str` -> `String` shouldn't need to waste space with a duplicate copy of this table.

@rustbot label A-unicode T-libs-api

r? @Mark-Simulacrum
rust-timer added a commit that referenced this pull request Apr 6, 2026
@rust-timer
Unrolled build for #154849
07b0923 
Rollup merge of #154849 - Jules-Bertholet:case-ignorable, r=Mark-Simulacrum

Promote `char::is_case_ignorable` from perma-unstable to unstable

(Take two of #154658, which was closed when GitHub Codespaces somehow managed to squash the entire commit history of rust-lang/rust into one commit)

This function is currently used in the implementation of `str::to_lowercase()`. There is no reason to restrict it to the stdlib, though. Reimplementations of string casing for types other than `str` -> `String` shouldn't need to waste space with a duplicate copy of this table.

@rustbot label A-unicode T-libs-api

r? @Mark-Simulacrum
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Apr 7, 2026
@JonathanBrouwer
Rollup merge of #154849 - Jules-Bertholet:case-ignorable, r=Mark-Simu…
d7b1dc5 
…lacrum

Promote `char::is_case_ignorable` from perma-unstable to unstable

(Take two of rust-lang/rust#154658, which was closed when GitHub Codespaces somehow managed to squash the entire commit history of rust-lang/rust into one commit)

This function is currently used in the implementation of `str::to_lowercase()`. There is no reason to restrict it to the stdlib, though. Reimplementations of string casing for types other than `str` -> `String` shouldn't need to waste space with a duplicate copy of this table.

@rustbot label A-unicode T-libs-api

r? @Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum requested changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-Unicode Area: Unicode T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jules-Bertholet @rustbot @Mark-Simulacrum