fix(lints): Improve ill_formed_attribute_input with better help message#154722
Open
JayanAXHF wants to merge 1 commit intorust-lang:mainfrom
Open
fix(lints): Improve ill_formed_attribute_input with better help message#154722JayanAXHF wants to merge 1 commit intorust-lang:mainfrom
ill_formed_attribute_input with better help message#154722JayanAXHF wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
r? me |
Contributor
|
This change seems to have no tests. Did no tests change or do we not have a test for this new behavior yet? |
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
…sage for the cases where it matches the usage of #![allow]
JayanAXHF
force-pushed
the
fix/update-ignore-error-message
branch
from
d60f71d to
94b8874
Compare
Member
Author
|
Oops forgot about that. @jdonszelmann I've added a test for this, lmk if there are any more changes to be made @rustbot ready |
rustbot
added
S-waiting-on-review
jdonszelmann
approved these changes
Apr 2, 2026
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
…uwer Rollup of 4 pull requests Successful merges: - #154444 (rustdoc ICE fix: When collecting `Deref` impls with their targets, skip the negative ones) - #154590 (Make #[cfg] suggest any or all on #[cfg(a, b)]) - #154691 (core: Update the feature gate on `TryFrom<integer> for bool`) - #154697 (rustdoc: fix href of extern crates in search results) Failed merges: - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a better help message to
ill_formed_attribute_inputfor the cases where it matches the usage of#![allow].For further details see #154667
closes #154667
cc: @Zalathar