Enforce #![warn(unreachable_pub)] in compiletest source#154741
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 3, 2026
Merged
Enforce #![warn(unreachable_pub)] in compiletest source#154741rust-bors[bot] merged 1 commit intorust-lang:mainfrom
#![warn(unreachable_pub)] in compiletest source#154741rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu
|
rustbot
added
A-compiletest
rustbot
added
the
T-bootstrap
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
jieyouxu
approved these changes
Apr 3, 2026
Contributor
rust-bors
bot
added
the
S-waiting-on-bors
rust-bors
bot
removed
the
S-waiting-on-review
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 3, 2026
Rollup of 6 pull requests Successful merges: - #154696 (rustdoc_missing_doc_code_examples: lint on macro_rules macros) - #154698 (Improve workings of the `desc` query modifier and custom query cycle handlers) - #154713 (Stop compiling when we get resolving crate failure) - #154736 (Add a regression test for the duplicated `crate` keyword in path suggestions) - #154739 (ci: update upload-artifact action to v7) - #154741 (Enforce `#![warn(unreachable_pub)]` in compiletest source) Failed merges: - #154605 (Make `span_suggestions` always verbose)
rust-timer
added a commit
that referenced
this pull request
Apr 3, 2026
Rollup merge of #154741 - Zalathar:unreachable-pub, r=jieyouxu Enforce `#![warn(unreachable_pub)]` in compiletest source The actual public API surface of compiletest is restricted to two specific modules, `cli` and `rustdoc_gui_test`. Other items have no reason to be `pub`. There should be no change to compiletest behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual public API surface of compiletest is restricted to two specific modules,
cliandrustdoc_gui_test.Other items have no reason to be
pub.There should be no change to compiletest behaviour.