Skip to content

Add a regression test for the duplicated crate keyword in path suggestions#154736

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
jakubadamw:issue-115858
Apr 3, 2026
Merged

Add a regression test for the duplicated crate keyword in path suggestions#154736
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
jakubadamw:issue-115858

Conversation

@jakubadamw
Copy link
Copy Markdown
Contributor

@jakubadamw jakubadamw commented Apr 2, 2026 •
edited by rustbot
Loading

The issue has (long) been fixed, but needs a test.

Closes #115858.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 2, 2026

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 12 candidates

@chenyukang
Copy link
Copy Markdown
Member

chenyukang commented Apr 3, 2026

Thanks!
@bors r=chenyukang

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 3, 2026

📌 Commit e2461cf has been approved by chenyukang

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2026
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 3, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of #154746 - matthiaskrgr:rollup-uWUN35u, r=matthiaskrgr
f908263 
Rollup of 6 pull requests

Successful merges:

 - #154696 (rustdoc_missing_doc_code_examples: lint on macro_rules macros)
 - #154698 (Improve workings of the `desc` query modifier and custom query cycle handlers)
 - #154713 (Stop compiling when we get resolving crate failure)
 - #154736 (Add a regression test for the duplicated `crate` keyword in path suggestions)
 - #154739 (ci: update upload-artifact action to v7)
 - #154741 (Enforce `#![warn(unreachable_pub)]` in compiletest source)

Failed merges:

 - #154605 (Make `span_suggestions` always verbose)
@rust-bors rust-bors bot merged commit 85c072e into rust-lang:main Apr 3, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 3, 2026
rust-timer added a commit that referenced this pull request Apr 3, 2026
@rust-timer
Unrolled build for #154736
8b51d2c 
Rollup merge of #154736 - jakubadamw:issue-115858, r=chenyukang

Add a regression test for the duplicated `crate` keyword in path suggestions

The issue has (long) been fixed, but needs a test.

Closes #115858.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@davidtwco davidtwco

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Bad path suggestion (duplicating crate keyword)

4 participants

@jakubadamw @rustbot @chenyukang @davidtwco