Make span_suggestions always verbose#154605
Conversation
|
Some changes occurred in tests/ui/sanitizer cc @rcvalle |
rustbot
added
PG-exploit-mitigations
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Makes sense to me, thanks.
One minor reservation I had while looking at the diffs is when the suggested snippet has placeholders, but then I still liked the verbose outline version over inline help (which is really hard to read IMO).
You can r=me after fixing CI.
@rustbot author
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
I saw the same thing and I'm looking at improving the suggestions to be more targeted for cases like those and rely on the "suggestion for full replacement" only as a fallback. |
`span_suggestions` is to provide mutually exclusive suggestions. When it was introduced, we made its behavior be that if a single suggestion is given to it, we present the suggestion inline, otherwise in patch format. Changing this to make all of its uses be verbose, as that is closer in intent of output.
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@bors r=jieyouxu |
rust-bors
bot
added
S-waiting-on-bors
rust-bors
bot
added
the
S-waiting-on-author
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts. This pull request was unapproved. |
rust-bors
bot
removed
the
S-waiting-on-bors
Rollup of 6 pull requests Successful merges: - #154696 (rustdoc_missing_doc_code_examples: lint on macro_rules macros) - #154698 (Improve workings of the `desc` query modifier and custom query cycle handlers) - #154713 (Stop compiling when we get resolving crate failure) - #154736 (Add a regression test for the duplicated `crate` keyword in path suggestions) - #154739 (ci: update upload-artifact action to v7) - #154741 (Enforce `#![warn(unreachable_pub)]` in compiletest source) Failed merges: - #154605 (Make `span_suggestions` always verbose)
4 participants
span_suggestionsis to provide mutually exclusive suggestions. When it was introduced, we made its behavior be that if a single suggestion is given to it, we present the suggestion inline, otherwise in patch format. Changing this to make all of its uses be verbose, as that is closer in intent of output.