Fix implied outlives check for GAT in RPITIT #116800

compiler-errors · 2023-10-16T15:44:52Z

We enforce certain Self: 'lt bounds for GATs to save space for more sophisticated implied bounds, but those currently operate on the HIR. Code was easily reworked to operate on def-ids so that we can properly let these suggestions propagate through synthetic associated types like RPITITs and AFITs.

r? @jackh726 or @aliemjay

Fixes #116789

rustbot · 2023-10-16T15:44:55Z

Could not assign reviewer from: jackh726.
User(s) jackh726 are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

rustbot · 2023-10-16T15:45:02Z

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

compiler-errors · 2023-10-16T15:45:40Z

r? aliemjay

jackh726 · 2023-10-16T17:20:46Z

@bors r+

bors · 2023-10-16T17:20:48Z

📌 Commit 17ec3cd has been approved by jackh726

It is now in the queue for this repository.

…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#116754 (coverage: Several small cleanups in `spans`) - rust-lang#116798 (Improve display of parallel jobs in rustdoc-gui tester script) - rust-lang#116800 (Fix implied outlives check for GAT in RPITIT) - rust-lang#116805 (Make `rustc_onunimplemented` export path agnostic) - rust-lang#116808 (Add myself to smir triage) - rust-lang#116811 (Preserve unicode escapes in format string literals when pretty-printing AST) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116800 - compiler-errors:rpitit-gat-outlives, r=jackh726 Fix implied outlives check for GAT in RPITIT We enforce certain `Self: 'lt` bounds for GATs to save space for more sophisticated implied bounds, but those currently operate on the HIR. Code was easily reworked to operate on def-ids so that we can properly let these suggestions propagate through synthetic associated types like RPITITs and AFITs. r? `@jackh726` or `@aliemjay` Fixes rust-lang#116789

Fix outlives suggestion for GAT in RPITIT

17ec3cd

rustbot assigned petrochenkov Oct 16, 2023

rustbot assigned aliemjay and unassigned petrochenkov Oct 16, 2023

compiler-errors changed the title ~~Fix self-outlives check for GAT in RPITIT~~ Fix implied outlives check for GAT in RPITIT Oct 16, 2023

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 16, 2023

GuillaumeGomez mentioned this pull request Oct 16, 2023

Rollup of 6 pull requests #116820

Merged

bors merged commit d0ade3f into rust-lang:master Oct 17, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 17, 2023

Veykril mentioned this pull request Oct 17, 2023

Pull upstream master 2023 10 17 ferrocene/ferrocene#54

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix implied outlives check for GAT in RPITIT #116800

Fix implied outlives check for GAT in RPITIT #116800

compiler-errors commented Oct 16, 2023 •

edited

Loading

rustbot commented Oct 16, 2023

rustbot commented Oct 16, 2023

compiler-errors commented Oct 16, 2023

jackh726 commented Oct 16, 2023

bors commented Oct 16, 2023

Fix implied outlives check for GAT in RPITIT #116800

Fix implied outlives check for GAT in RPITIT #116800

Conversation

compiler-errors commented Oct 16, 2023 • edited Loading

rustbot commented Oct 16, 2023

rustbot commented Oct 16, 2023

compiler-errors commented Oct 16, 2023

jackh726 commented Oct 16, 2023

bors commented Oct 16, 2023

compiler-errors commented Oct 16, 2023 •

edited

Loading