Add the V (vector) extension to the riscv64-linux-android target spec #116618

chriswailes · 2023-10-10T23:31:19Z

This feature has been enabled and tested internally in the Android project.

rustbot · 2023-10-10T23:31:28Z

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-10-10T23:31:31Z

These commits modify compiler targets.
(See the Target Tier Policy.)

workingjubilee · 2023-10-11T19:53:03Z

This is a tier 3 target, so arbitrary fiddling with its spec is permitted, and it does not encode extensions like gc into its name, so there is no question of whether it should be riscv64gcv-linux-android. And, yk, it's the target maintainer.

But I do think we should do one thing.

@chriswailes Can you mention the ISA requirements in the platform support file? You can use "currently... at least..." kind of cagey terminology if you want to avoid committing to stuff, but if someone out there tries this on a random RV64 board, even if they had previously gotten Android working on it, it's likely to fail now, and some boards claim they support the V extension but actually support a pre-ratification version only which is not binary-compatible with the finalized version. It'd be nice to not ask people to gaze into the rustc source to find out why.

This commit adds additional documentation describing the features/extensions required by the riscv64-linux-android target.

chriswailes · 2023-10-12T00:04:47Z

Sure thing! Thanks for the great suggestion. I debated being a little tricky with the list and doing something like:

* a(tomics)
* d(ouble-precision floating-point)

but eventually decided against it. Let me know if you'd like any changes or additions to the documentation.

workingjubilee · 2023-10-12T20:11:49Z

Thank you!

I know it's common for SBC makers and the like to carry a bunch of patches for a while until they get stuff upstreamed, so if anyone is already in the process of putting Rust and Android on RV64, hopefully this makes life easier for them.

@bors r+

bors · 2023-10-12T20:11:51Z

📌 Commit 899f81f has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2023-10-13T03:48:55Z

⌛ Testing commit 899f81f with merge 0428798...

…ctor, r=workingjubilee Add the V (vector) extension to the riscv64-linux-android target spec This feature has been enabled and tested internally in the Android project.

taiki-e · 2023-10-13T04:02:01Z

compiler/rustc_target/src/spec/riscv64_linux_android.rs

@@ -9,7 +9,7 @@ pub fn target() -> Target {
        options: TargetOptions {
            code_model: Some(CodeModel::Medium),
            cpu: "generic-rv64".into(),
-            features: "+m,+a,+f,+d,+c,+Zba,+Zbb,+Zbs".into(),
+            features: "+m,+a,+f,+d,+c,+Zba,+Zbb,+Zbs,+V".into(),


I think these need to be lower case.

Suggested change

features: "+m,+a,+f,+d,+c,+Zba,+Zbb,+Zbs,+V".into(),

features: "+m,+a,+f,+d,+c,+zba,+zbb,+zbs,+v".into(),

rust/compiler/rustc_codegen_ssa/src/target_features.rs

Lines 255 to 257 in 130ff8c

("v", Some(sym::riscv_target_feature)),

("zba", Some(sym::riscv_target_feature)),

("zbb", Some(sym::riscv_target_feature)),

The current one generates "recognized feature" warnings.

'+Zba' is not a recognized feature for this target (ignoring feature) '+Zbb' is not a recognized feature for this target (ignoring feature) '+Zbs' is not a recognized feature for this target (ignoring feature) '+V' is not a recognized feature for this target (ignoring feature)

https://godbolt.org/z/cEq1d6vK6

...Wow that's annoying.

Thank you both.

workingjubilee · 2023-10-13T04:34:54Z

Eh, really?
@bors r-

bors · 2023-10-13T05:34:23Z

☀️ Try build successful - checks-actions
Build commit: 0428798 (04287982ef974631b34b2cf0ee19fc220d89e707)

workingjubilee · 2023-10-13T20:27:30Z

rustc... really should have caught that on its own.

Anyway,
@bors r+

bors · 2023-10-13T20:27:31Z

📌 Commit 166c353 has been approved by workingjubilee

It is now in the queue for this repository.

…vector, r=workingjubilee Add the V (vector) extension to the riscv64-linux-android target spec This feature has been enabled and tested internally in the Android project.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#115653 (Guarantee that Layout::align returns a non-zero power of two) - rust-lang#116577 (add `SAFETY` block on the usage of unsafe `getuid`) - rust-lang#116618 (Add the V (vector) extension to the riscv64-linux-android target spec) - rust-lang#116679 (Remove some unnecessary `unwrap`s) - rust-lang#116689 (explicitly handle auto trait leakage in coherence) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116618 - chriswailes:riscv64-linux-android-vector, r=workingjubilee Add the V (vector) extension to the riscv64-linux-android target spec This feature has been enabled and tested internally in the Android project.

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * For an external LLVM, set dependency of llvm >= 16, in accordance with the upstream changes. * Mark that on NetBSD we now need >= 9.0, so 8.x is no longer supported. * On NetBSD/sparc64 10.x, we now need GCC 12 to build the embedded LLVM, which is version 17; apparently GCC 10.4 or 10.5 mis-compiles it, resulting in an illegal instruction fault during the build. Ref. rust-lang/rust#117231 Upstream changes: Version 1.75.0 (2023-12-28) ========================== - [Stabilize `async fn` and return-position `impl Trait` in traits.] (rust-lang/rust#115822) - [Allow function pointer signatures containing `&mut T` in `const` contexts.] (rust-lang/rust#116015) - [Match `usize`/`isize` exhaustively with half-open ranges.] (rust-lang/rust#116692) - [Guarantee that `char` has the same size and alignment as `u32`.] (rust-lang/rust#116894) - [Document that the null pointer has the 0 address.] (rust-lang/rust#116988) - [Allow partially moved values in `match`.] (rust-lang/rust#103208) - [Add notes about non-compliant FP behavior on 32bit x86 targets.] (rust-lang/rust#113053) - [Stabilize ratified RISC-V target features.] (rust-lang/rust#116485) Compiler -------- - [Rework negative coherence to properly consider impls that only partly overlap.] (rust-lang/rust#112875) - [Bump `COINDUCTIVE_OVERLAP_IN_COHERENCE` to deny, and warn in dependencies.] (rust-lang/rust#116493) - [Consider alias bounds when computing liveness in NLL.] (rust-lang/rust#116733) - [Add the V (vector) extension to the `riscv64-linux-android` target spec.] (rust-lang/rust#116618) - [Automatically enable cross-crate inlining for small functions] (rust-lang/rust#116505) - Add several new tier 3 targets: - [`csky-unknown-linux-gnuabiv2hf`] (rust-lang/rust#117049) - [`i586-unknown-netbsd`] (rust-lang/rust#117170) - [`mipsel-unknown-netbsd`] (rust-lang/rust#117356) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Override `Waker::clone_from` to avoid cloning `Waker`s unnecessarily.] (rust-lang/rust#96979) - [Implement `BufRead` for `VecDeque<u8>`.] (rust-lang/rust#110604) - [Implement `FusedIterator` for `DecodeUtf16` when the inner iterator does.] (rust-lang/rust#110729) - [Implement `Not, Bit{And,Or}{,Assign}` for IP addresses.] (rust-lang/rust#113747) - [Implement `Default` for `ExitCode`.] (rust-lang/rust#114589) - [Guarantee representation of None in NPO] (rust-lang/rust#115333) - [Document when atomic loads are guaranteed read-only.] (rust-lang/rust#115577) - [Broaden the consequences of recursive TLS initialization.] (rust-lang/rust#116172) - [Windows: Support sub-millisecond sleep.] (rust-lang/rust#116461) - [Fix generic bound of `str::SplitInclusive`'s `DoubleEndedIterator` impl] (rust-lang/rust#100806) - [Fix exit status / wait status on non-Unix `cfg(unix)` platforms.] (rust-lang/rust#115108) Stabilized APIs --------------- - [`Atomic*::from_ptr`] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicUsize.html#method.from_ptr) - [`FileTimes`] (https://doc.rust-lang.org/stable/std/fs/struct.FileTimes.html) - [`FileTimesExt`] (https://doc.rust-lang.org/stable/std/os/windows/fs/trait.FileTimesExt.html) - [`File::set_modified`] (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.set_modified) - [`File::set_times`] (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.set_times) - [`IpAddr::to_canonical`] (https://doc.rust-lang.org/stable/core/net/enum.IpAddr.html#method.to_canonical) - [`Ipv6Addr::to_canonical`] (https://doc.rust-lang.org/stable/core/net/struct.Ipv6Addr.html#method.to_canonical) - [`Option::as_slice`] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.as_slice) - [`Option::as_mut_slice`] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.as_mut_slice) - [`pointer::byte_add`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.byte_add) - [`pointer::byte_offset`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.byte_offset) - [`pointer::byte_offset_from`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.byte_offset_from) - [`pointer::byte_sub`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.byte_sub) - [`pointer::wrapping_byte_add`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.wrapping_byte_add) - [`pointer::wrapping_byte_offset`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.wrapping_byte_offset) - [`pointer::wrapping_byte_sub`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.wrapping_byte_sub) These APIs are now stable in const contexts: - [`Ipv6Addr::to_ipv4_mapped`] (https://doc.rust-lang.org/stable/core/net/struct.Ipv6Addr.html#method.to_ipv4_mapped) - [`MaybeUninit::assume_init_read`] (https://doc.rust-lang.org/stable/core/mem/union.MaybeUninit.html#method.assume_init_read) - [`MaybeUninit::zeroed`] (https://doc.rust-lang.org/stable/core/mem/union.MaybeUninit.html#method.zeroed) - [`mem::discriminant`] (https://doc.rust-lang.org/stable/core/mem/fn.discriminant.html) - [`mem::zeroed`] (https://doc.rust-lang.org/stable/core/mem/fn.zeroed.html) Cargo ----- - [Add new packages to `[workspace.members]` automatically.] (rust-lang/cargo#12779) - [Allow version-less `Cargo.toml` manifests.] (rust-lang/cargo#12786) - [Make browser links out of HTML file paths.] (rust-lang/cargo#12889) Rustdoc ------- - [Accept less invalid Rust in rustdoc.] (rust-lang/rust#117450) - [Document lack of object safety on affected traits.] (rust-lang/rust#113241) - [Hide `#[repr(transparent)]` if it isn't part of the public ABI.] (rust-lang/rust#115439) - [Show enum discriminant if it is a C-like variant.] (rust-lang/rust#116142) Compatibility Notes ------------------- - [FreeBSD targets now require at least version 12.] (rust-lang/rust#114521) - [Formally demote tier 2 MIPS targets to tier 3.] (rust-lang/rust#115238) - [Make misalignment a hard error in `const` contexts.] (rust-lang/rust#115524) - [Fix detecting references to packed unsized fields.] (rust-lang/rust#115583) - [Remove support for compiler plugins.] (rust-lang/rust#116412)

Add the V (vector) extension to the riscv64-linux-android target spec

6efc71c

This feature has been enabled and tested internally in the Android project.

rustbot assigned davidtwco Oct 10, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 10, 2023

Add documentation for the riscv64-android-linux target

899f81f

This commit adds additional documentation describing the features/extensions required by the riscv64-linux-android target.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2023

taiki-e reviewed Oct 13, 2023

View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 13, 2023

Lowercase the feature flags for riscv64-linux-android

166c353

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2023

This was referenced Oct 14, 2023

Rollup of 6 pull requests #116726

Closed

Rollup of 5 pull requests #116728

Merged

bors merged commit f29dbe8 into rust-lang:master Oct 14, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 14, 2023

Veykril mentioned this pull request Oct 17, 2023

Pull upstream master 2023 10 17 ferrocene/ferrocene#54

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the V (vector) extension to the riscv64-linux-android target spec #116618

Add the V (vector) extension to the riscv64-linux-android target spec #116618

chriswailes commented Oct 10, 2023

rustbot commented Oct 10, 2023

rustbot commented Oct 10, 2023

workingjubilee commented Oct 11, 2023

chriswailes commented Oct 12, 2023

workingjubilee commented Oct 12, 2023

bors commented Oct 12, 2023

bors commented Oct 13, 2023

taiki-e Oct 13, 2023

workingjubilee Oct 13, 2023

chriswailes Oct 13, 2023

workingjubilee Oct 13, 2023

workingjubilee commented Oct 13, 2023

bors commented Oct 13, 2023

workingjubilee commented Oct 13, 2023

bors commented Oct 13, 2023

	features: "+m,+a,+f,+d,+c,+Zba,+Zbb,+Zbs,+V".into(),
	features: "+m,+a,+f,+d,+c,+zba,+zbb,+zbs,+v".into(),

	("v", Some(sym::riscv_target_feature)),
	("zba", Some(sym::riscv_target_feature)),
	("zbb", Some(sym::riscv_target_feature)),

Add the V (vector) extension to the riscv64-linux-android target spec #116618

Add the V (vector) extension to the riscv64-linux-android target spec #116618

Conversation

chriswailes commented Oct 10, 2023

rustbot commented Oct 10, 2023

rustbot commented Oct 10, 2023

workingjubilee commented Oct 11, 2023

chriswailes commented Oct 12, 2023

workingjubilee commented Oct 12, 2023

bors commented Oct 12, 2023

bors commented Oct 13, 2023

taiki-e Oct 13, 2023

Choose a reason for hiding this comment

workingjubilee Oct 13, 2023

Choose a reason for hiding this comment

chriswailes Oct 13, 2023

Choose a reason for hiding this comment

workingjubilee Oct 13, 2023

Choose a reason for hiding this comment

workingjubilee commented Oct 13, 2023

bors commented Oct 13, 2023

workingjubilee commented Oct 13, 2023

bors commented Oct 13, 2023