Merged
Conversation
kyrofa
reviewed
Jun 20, 2019
kyrofa
approved these changes
Jun 20, 2019
Member
kyrofa
left a comment
kyrofa
left a comment
There was a problem hiding this comment.
Thanks for this, @mikaelarguedas! Also, no problem, happy to deconflict if necessary.
mikaelarguedas
force-pushed
the
follow-up-125
branch
from
43ae72f to
3e40ed0
Compare
Member
Author
|
Rebased and deconflicted |
mjcarroll
approved these changes
Jun 24, 2019
Member
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas
force-pushed
the
follow-up-125
branch
from
3e40ed0 to
46cb46a
Compare
Member
Author
|
Rebased and deconflicted again |
mjcarroll
approved these changes
Jun 26, 2019
ruffsl
pushed a commit
to ruffsl/sros2
that referenced
this pull request
Aug 6, 2019
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com> Signed-off-by: ruffsl <roxfoxpox@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the permissions check to test not only that it's valid xml but also a valid permission file.
Rename argument to highlight that it's unused
@kyrofa FYI it may conflict with #132, but can be easily rebased if 132 gets in before this