Skip to content

Fix 137: removes hardcoded sros2testCA#139

Merged
mjcarroll merged 1 commit intoros2:masterfrom
mikaelarguedas:fix_137
Jun 27, 2019
Merged

Fix 137: removes hardcoded sros2testCA#139
mjcarroll merged 1 commit intoros2:masterfrom
mikaelarguedas:fix_137

Conversation

@mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas commented Jun 26, 2019

To be merged after #133
Fixes #137

Relevant commit to review: 33fedeb

@mjcarroll
Copy link
Member

Covering #137 + #133

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@kyrofa
Copy link
Member

kyrofa commented Jun 26, 2019

(few conflicts here)

@mjcarroll
Copy link
Member

Oh yeah, @mikaelarguedas mind a quick rebase here?

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mjcarroll mjcarroll merged commit 6a3af25 into ros2:master Jun 27, 2019
@mikaelarguedas mikaelarguedas deleted the fix_137 branch June 27, 2019 01:39
ruffsl pushed a commit to ruffsl/sros2 that referenced this pull request Aug 6, 2019
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace all hardcoded "sros2testCA" with constant DEFAULT_COMMON_NAME

3 participants