api: migrate create_key to cryptography library#138
Merged
jacobperron merged 1 commit intoros2:masterfrom Jun 26, 2019
Merged
Conversation
Contributor
|
Woohoo love deleting code - this also closes #109? Or is there still followup needed EDIT: Oh I see that the commit message says so :) |
Member
Author
|
Yessir, the commit message should make that happen (I've updated the description as well, sorry about that). This still needs a refactor pretty badly (e.g. we're doing a lot more file I/O than we need to be doing now), but that's outside of #109. |
This completes the migration from shelling out to `openssl` to the cryptography library. Resolve ros2#109 Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
feature/create_key_cryptography
branch
from
d6e9ef7 to
782f794
Compare
jacobperron
approved these changes
Jun 26, 2019
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
LGTM
- Linux
- Linux-aarch64
- macOS
- Windows
Merged
ruffsl
pushed a commit
to ruffsl/sros2
that referenced
this pull request
Aug 6, 2019
This completes the migration from shelling out to `openssl` to the cryptography library. Resolve ros2#109 Signed-off-by: Kyle Fazzari <kyle@canonical.com> Signed-off-by: ruffsl <roxfoxpox@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #109 by completing the migration from shelling out to
opensslto the cryptography library.