Skip to content

Fix failure to build by using rcpputils instead of pluginlib impl#247

Closed
sloretz wants to merge 1 commit intofoxy-develfrom
use_rcpputils_instead_of_pluginlib_impl
Closed

Fix failure to build by using rcpputils instead of pluginlib impl#247
sloretz wants to merge 1 commit intofoxy-develfrom
use_rcpputils_instead_of_pluginlib_impl

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Feb 12, 2021

Fixes failure to build caused by pluginlib's implementation changing:
ros/pluginlib#212

Note for reviewer: this fix is also required to build on my machine ament/ament_cmake#318

Signed-off-by: Shane Loretz sloretz@openrobotics.org
Signed-off-by: Shane Loretz sloretz@osrfoundation.org

Fixes failure to build caused by pluginlib's implementation changing:
ros/pluginlib#212

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the bug label Feb 12, 2021
@sloretz sloretz requested a review from clalancette February 12, 2021 19:58
@sloretz sloretz self-assigned this Feb 12, 2021
@clalancette
Copy link
Copy Markdown
Contributor

Hm, should this PR be necessary? That is, as far as I know I only put the change to use rcpputils on the ros2 branch of pluginlib, not on the foxy branch. I deliberately did that because ros/pluginlib#212 was an API break.

Additionally, as far as I can tell foxy builds correctly right now. At least, I did a build this morning and it all seemed to build. @sloretz can you give a bit more information on where the need for this PR came from?

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Feb 12, 2021

Additionally, as far as I can tell foxy builds correctly right now. At least, I did a build this morning and it all seemed to build. @sloretz can you give a bit more information on where the need for this PR came from?

Gah, I closed the wrong PR 🤦 ament/ament_cmake#318 (comment)

@sloretz sloretz closed this Feb 12, 2021
@sloretz sloretz deleted the use_rcpputils_instead_of_pluginlib_impl branch February 12, 2021 23:21
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Feb 12, 2021

can you give a bit more information on where the need for this PR came from?

The PR came from pulling changes to my ROS 2 workspace, but not re-importing the latest ros2.repos file. It still listed this repo's foxy-devel branch. My mistake combined with a quirk of our git branching strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants