Use rcpputils for the filesystem implementation.#212
Merged
clalancette merged 1 commit intoros2from Jan 13, 2021
Merged
Conversation
Contributor
Author
|
CI:
|
Contributor
Author
|
All right, this has to wait to go in until ros2/rcpputils#112 is merged. After that, it should pass tests. |
mjcarroll
approved these changes
Nov 5, 2020
Member
mjcarroll
left a comment
mjcarroll
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Contributor
Author
|
@ros-pull-request-builder retest this please |
Contributor
Author
|
CI:
|
This gets rid of a whole bunch of custom logic and duplicated code around filesystem manipulation. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
use-rcpputils-filesystem
branch
from
4065f0c to
f63d90f
Compare
Contributor
Author
|
Now that we've merged ros2/rcpputils#118, this should be a lot easier. Let's try CI again:
|
Karsten1987
approved these changes
Jan 12, 2021
Contributor
Author
|
The one failing test on macOS often fails on the nightlies: https://ci.ros2.org/view/nightly/job/nightly_osx_repeated/2218/#showFailuresLink . So I'm going to go ahead and merge this. |
This was referenced Jan 13, 2021
Closed
sloretz
added a commit
to ros-visualization/qt_gui_core
that referenced
this pull request
Feb 12, 2021
Fixes failure to build caused by pluginlib's implementation changing: ros/pluginlib#212 Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets rid of a whole bunch of custom logic and duplicated
code around filesystem manipulation.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
If I understand the situation correctly, this should supersede #209, #185, and #184, and may fix #168.
@Karsten1987, @rotu, @jpardeiro FYI.