Conversation
Some packages have multiple configurations, but this code was assuming there would only be one. This results in a CMake error about and incorrect number of arguments passed to get_target_property(). From `--trace-expand` output ``` get_target_property(imported_implib rcpputils::rcpputils IMPORTED_IMPLIB_DEBUG;NOCONFIG ) CMake Error at :58 (get_target_property): :47 (ament_get_recursive_properties) src/qt_gui_cpp_shiboken/CMakeLists.txt:39 (ament_get_recursive_properties) ``` Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Contributor
Author
|
Edit oops, closed wrong PR
|
Contributor
Author
|
reopening because I closed the wrong PR :( |
hidmic
approved these changes
Feb 15, 2021
hidmic
left a comment
hidmic
left a comment
There was a problem hiding this comment.
Looks reasonable to me, pending green CI
|
@sloretz do you still want to merge this PR? |
Contributor
Author
|
CI (build:
|
|
That Windows warning seems unrelated. I think this is ready to go @sloretz. |
Contributor
Author
|
Ah, thanks! I forgot about this one. |
delete-merged-branch
bot
deleted the
ament_cmake__get_recursive_properties_for_all_configurations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some packages have multiple configurations, but this code was assuming
there would only be one. This results in a CMake error about and
incorrect number of arguments passed to get_target_property().
This fixes it by grabbing data from all configurations.
From
--trace-expandoutputSigned-off-by: Shane Loretz sloretz@openrobotics.org
Signed-off-by: Shane Loretz sloretz@osrfoundation.org