Skip to content

[melodic] Fix travis CI#269

Merged
mjcarroll merged 1 commit intoros-perception:melodicfrom
seanyen:melodic_travis_fix
Jul 9, 2019
Merged

[melodic] Fix travis CI#269
mjcarroll merged 1 commit intoros-perception:melodicfrom
seanyen:melodic_travis_fix

Conversation

@seanyen
Copy link
Copy Markdown
Contributor

@seanyen seanyen commented Feb 24, 2019

Fix travis CI build for melodic. The change is adapted from tork-a/visualization_rwt@4a93906.

One standing error is test_encode_decode_cv2_compressed failure, which is also reproducible on Mpr__vision_opencv__ubuntu_bionic_amd64 build.

======================================================================
ERROR: test_encode_decode_cv2_compressed (conversions.TestConversions)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/catkin_ws/src/vision_opencv/cv_bridge/test/conversions.py", line 64, in test_encode_decode_cv2_compressed
    compress_rosmsg = cvb_en.cv2_to_compressed_imgmsg(original, f)
  File "/home/travis/catkin_ws/src/vision_opencv/cv_bridge/python/cv_bridge/core.py", line 219, in cv2_to_compressed_imgmsg
    cmprs_img_msg.data = np.array(cv2.imencode(ext_format, cvim)[1]).tostring()
error: /build/opencv-L2vuMj/opencv-3.2.0+dfsg/modules/imgcodecs/src/loadsave.cpp:783: error: (-2) could not find encoder for the specified extension in function imencode

@seanyen
Copy link
Copy Markdown
Contributor Author

seanyen commented Feb 24, 2019

After checking the failing format, it is jp2 in test_encode_decode_cv2_compressed. Perhaps we should consider cherry-pick #242 too?

@seanyen
Copy link
Copy Markdown
Contributor Author

seanyen commented Mar 4, 2019

@mjcarroll Hope I am pinging the correct person. There are some PRs created recently for bringing up vision_opencv for Windows build, which is verified on https://aka.ms/ros project. Hope I can get some feedbacks and see how to make those changes merged back and available for Windows users. Thanks!

Here is a list for all related PRs for quick reference:
#269 (This one is nice to have, so we know no test regression seen from the Windows changes.)
#267
#266
#265

@seanyen
Copy link
Copy Markdown
Contributor Author

seanyen commented Jul 3, 2019

@mjcarroll Sorry to ping you again. Any chance to take a look and see how I can move the Windows related PR forward?

@mjcarroll mjcarroll merged commit a1f67f6 into ros-perception:melodic Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants