update CMakeLists.txt for Windows build environment#265
Merged
mjcarroll merged 7 commits intoros-perception:melodicfrom Mar 28, 2020
Merged
update CMakeLists.txt for Windows build environment#265mjcarroll merged 7 commits intoros-perception:melodicfrom
mjcarroll merged 7 commits intoros-perception:melodicfrom
Conversation
This was referenced Mar 4, 2019
Merged
Contributor
kejxu
force-pushed
the
export_runtime_binaries_on_windows
branch
from
5a09095 to
04d4135
Compare
Author
|
@mjcarroll seems like travis is working now =) |
Contributor
|
@mjcarroll Just a friendly ping, this is ready for review and merge. |
Contributor
|
@mjcarroll Friendly ping. |
mjcarroll
approved these changes
Mar 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update
CMakeLists.txtfor Windows build environmentRUNTIME_OUTPUT_DIRECTORYis needed so that.dllwould be exportedif(MSVC)special handlingRUNTIME DESTINATIONshould be${CATKIN_GLOBAL_BIN_DESTINATION}for.dllon Windows based on catkin recommendation