[Windows][melodic] remove path splash separator from 'package_dir'#267
Merged
mjcarroll merged 1 commit intoros-perception:melodicfrom Jul 10, 2019
Merged
Conversation
This was referenced Mar 4, 2019
Merged
Contributor
|
@seanyen Can you give this a quick rebase on the latest melodic branch to see that it works with travis? |
86f987b to
ff18198
Compare
Contributor
Author
|
@mjcarroll I just did a rebase and it seemed the CI result looking good. |
mjcarroll
approved these changes
Jul 10, 2019
Contributor
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running catkin_make (or catkin_make_isolated) on Windows,
distutilsthrows errors forcv_bridge. And it turned out thatdistutilsdoesn't like the path separator not matched to the underlying OS convention insetup.py.Per the example in
catkindoc, it is not mandatory to tail thepackage_dirwith/so it can be easily fixed by removing it and make the code more portable.