Add namespace for Rotation Shim primary controller for better dynamic parameters handling#5654
Merged
SteveMacenski merged 12 commits intoros-navigation:mainfrom Nov 18, 2025
Conversation
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
SteveMacenski
approved these changes
Nov 18, 2025
decwest
pushed a commit
to decwest/navigation2
that referenced
this pull request
Dec 10, 2025
… parameters handling (ros-navigation#5654) * Redesign rotation shim dynamic parameters patterns Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Use new api Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Linting Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add namespace for primary controller Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add warning for migration guide Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Throw if parameter does not exist Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Clang tidy Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
decwest
pushed a commit
to decwest/navigation2
that referenced
this pull request
Dec 11, 2025
… parameters handling (ros-navigation#5654) * Redesign rotation shim dynamic parameters patterns Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Use new api Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Linting Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add namespace for primary controller Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add warning for migration guide Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Throw if parameter does not exist Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Clang tidy Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.