-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Refactor parameter handler #5667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SteveMacenski
merged 5 commits into
ros-navigation:main
from
mini-1235:refactor/dynamic_params
Nov 24, 2025
Merged
Refactor parameter handler #5667
SteveMacenski
merged 5 commits into
ros-navigation:main
from
mini-1235:refactor/dynamic_params
Nov 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mini-1235 <[email protected]>
Collaborator
Author
|
@SteveMacenski, if you agree on this PR I can rebase #5654 and #5446 |
Signed-off-by: mini-1235 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 23 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
mini-1235
commented
Nov 5, 2025
SteveMacenski
approved these changes
Nov 24, 2025
Decwest
pushed a commit
to Decwest/navigation2
that referenced
this pull request
Dec 10, 2025
* Refactor parameter handler Signed-off-by: mini-1235 <[email protected]> * Precommit Signed-off-by: mini-1235 <[email protected]> * Clang tidy Signed-off-by: mini-1235 <[email protected]> * Clang tidy Signed-off-by: mini-1235 <[email protected]> * Fix readability Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]>
Decwest
pushed a commit
to Decwest/navigation2
that referenced
this pull request
Dec 11, 2025
* Refactor parameter handler Signed-off-by: mini-1235 <[email protected]> * Precommit Signed-off-by: mini-1235 <[email protected]> * Clang tidy Signed-off-by: mini-1235 <[email protected]> * Clang tidy Signed-off-by: mini-1235 <[email protected]> * Fix readability Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> Signed-off-by: Decwest <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.