Skip to content

Integrate ClearCostmapExceptRegion and ClearCostmapAroundRobot Services into the API#4962

Merged
SteveMacenski merged 3 commits intoros-navigation:mainfrom
BCKSELFDRIVEWORLD:navigator_api
Mar 6, 2025
Merged

Integrate ClearCostmapExceptRegion and ClearCostmapAroundRobot Services into the API#4962
SteveMacenski merged 3 commits intoros-navigation:mainfrom
BCKSELFDRIVEWORLD:navigator_api

Conversation

@BCKSELFDRIVEWORLD
Copy link
Contributor

Many Nav2 users initially assume that the only available option is to clear the entire costmap. To raise awareness and highlight additional costmap clearing options already available

@SteveMacenski
Copy link
Member

SteveMacenski commented Mar 6, 2025

@BCKSELFDRIVEWORLD check the linter / DCO, then happy to merge once CI is green :-)

E ./nav2_simple_commander/robot_navigator.py:38:1: I101 Imported names are in the wrong order. Should be ClearCostmapAroundRobot, ClearCostmapExceptRegion, ClearEntireCostmap

…BasicNavigator API

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>
Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>
Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SteveMacenski SteveMacenski merged commit ec4481a into ros-navigation:main Mar 6, 2025
11 checks passed
SteveMacenski pushed a commit that referenced this pull request Apr 15, 2025
…es into the API (#4962)

* Add ClearCostmapExceptRegion and ClearCostmapAroundRobot services to BasicNavigator API

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

* typo ament_flake8

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

* type fix ament_flake

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

---------

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>
SteveMacenski added a commit that referenced this pull request Apr 15, 2025
* Add short delay before lookup transform in polygon test (#4939)

* Add short delay before lookup transform

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix linting

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Populate stamped command message with now timestamp, if velocity timed out. (#4959)

Signed-off-by: Georg Flick <georg.flick@enway.ai>

* Integrate ClearCostmapExceptRegion and ClearCostmapAroundRobot Services into the API (#4962)

* Add ClearCostmapExceptRegion and ClearCostmapAroundRobot services to BasicNavigator API

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

* typo ament_flake8

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

* type fix ament_flake

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

---------

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

* Fix urls in node hybrid (#4973)

Signed-off-by: mattbooker <mattbooker97@gmail.com>

* Use main function to replace global variable in gtest. (#4978)

Signed-off-by: ChenYing Kuo <evshary@gmail.com>

* nav2_behavior_tree: fix input port parsing error in AreErrorCodesPresent (#4986)

The getInput method does not support std::set<uint16_t> parsing. So,
let's replace the type of the input port by std::vector<int> which is
supported, and convert the list to a std::set<uint16_t>.

This commit fixes issue #4985.

Signed-off-by: Dylan De Coeyer <dylan.decoeyer@quimesis.be>

* Change to goal checker orientation for yaw angle (#4988)

- Fixed discrepancy in goal checker orientation, which was checking for
< tolerance instead of <= tolerance, as all the other limit checks are.
- Reduced tolerance time for the progress checker unit tests to
0.1 seconds, to reduce test runtime from ~17 to ~7 seconds.

Signed-off-by: Rasmus Larsson <rasmus.larsson@accenture.com>

* Declare_parameter_if_not_declared in docking navigator (#5023)

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* bumping to 1.3.6 for release

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Georg Flick <georg.flick@enway.ai>
Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>
Signed-off-by: mattbooker <mattbooker97@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: Dylan De Coeyer <dylan.decoeyer@quimesis.be>
Signed-off-by: Rasmus Larsson <rasmus.larsson@accenture.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: mini-1235 <58433591+mini-1235@users.noreply.github.com>
Co-authored-by: Georg Flick <54032815+georgflick@users.noreply.github.com>
Co-authored-by: Burak Can Kaya <146545020+BCKSELFDRIVEWORLD@users.noreply.github.com>
Co-authored-by: Matthew Booker <mattbooker97@gmail.com>
Co-authored-by: ChenYing Kuo (CY) <evshary@gmail.com>
Co-authored-by: DylanDeCoeyer-Quimesis <102609575+DylanDeCoeyer-Quimesis@users.noreply.github.com>
Co-authored-by: RasmusLar <101558931+RasmusLar@users.noreply.github.com>
Co-authored-by: Alberto Tudela <ajtudela@gmail.com>
stevedanomodolor pushed a commit to stevedanomodolor/navigation2 that referenced this pull request Apr 29, 2025
…es into the API (ros-navigation#4962)

* Add ClearCostmapExceptRegion and ClearCostmapAroundRobot services to BasicNavigator API

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

* typo ament_flake8

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

* type fix ament_flake

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

---------

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>
Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants