Fix the message header timestamp of the velocity_smoother, when the input timed out#4959
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Mar 5, 2025
Conversation
…d out. Signed-off-by: Georg Flick <georg.flick@enway.ai>
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
SteveMacenski
approved these changes
Mar 5, 2025
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
Nice, I think this does it perfectly, thanks for the PR!
SteveMacenski
pushed a commit
that referenced
this pull request
Apr 15, 2025
…d out. (#4959) Signed-off-by: Georg Flick <georg.flick@enway.ai>
SteveMacenski
added a commit
that referenced
this pull request
Apr 15, 2025
* Add short delay before lookup transform in polygon test (#4939) * Add short delay before lookup transform Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix linting Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Populate stamped command message with now timestamp, if velocity timed out. (#4959) Signed-off-by: Georg Flick <georg.flick@enway.ai> * Integrate ClearCostmapExceptRegion and ClearCostmapAroundRobot Services into the API (#4962) * Add ClearCostmapExceptRegion and ClearCostmapAroundRobot services to BasicNavigator API Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com> * typo ament_flake8 Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com> * type fix ament_flake Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com> --------- Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com> * Fix urls in node hybrid (#4973) Signed-off-by: mattbooker <mattbooker97@gmail.com> * Use main function to replace global variable in gtest. (#4978) Signed-off-by: ChenYing Kuo <evshary@gmail.com> * nav2_behavior_tree: fix input port parsing error in AreErrorCodesPresent (#4986) The getInput method does not support std::set<uint16_t> parsing. So, let's replace the type of the input port by std::vector<int> which is supported, and convert the list to a std::set<uint16_t>. This commit fixes issue #4985. Signed-off-by: Dylan De Coeyer <dylan.decoeyer@quimesis.be> * Change to goal checker orientation for yaw angle (#4988) - Fixed discrepancy in goal checker orientation, which was checking for < tolerance instead of <= tolerance, as all the other limit checks are. - Reduced tolerance time for the progress checker unit tests to 0.1 seconds, to reduce test runtime from ~17 to ~7 seconds. Signed-off-by: Rasmus Larsson <rasmus.larsson@accenture.com> * Declare_parameter_if_not_declared in docking navigator (#5023) Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * bumping to 1.3.6 for release Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Georg Flick <georg.flick@enway.ai> Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com> Signed-off-by: mattbooker <mattbooker97@gmail.com> Signed-off-by: ChenYing Kuo <evshary@gmail.com> Signed-off-by: Dylan De Coeyer <dylan.decoeyer@quimesis.be> Signed-off-by: Rasmus Larsson <rasmus.larsson@accenture.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: mini-1235 <58433591+mini-1235@users.noreply.github.com> Co-authored-by: Georg Flick <54032815+georgflick@users.noreply.github.com> Co-authored-by: Burak Can Kaya <146545020+BCKSELFDRIVEWORLD@users.noreply.github.com> Co-authored-by: Matthew Booker <mattbooker97@gmail.com> Co-authored-by: ChenYing Kuo (CY) <evshary@gmail.com> Co-authored-by: DylanDeCoeyer-Quimesis <102609575+DylanDeCoeyer-Quimesis@users.noreply.github.com> Co-authored-by: RasmusLar <101558931+RasmusLar@users.noreply.github.com> Co-authored-by: Alberto Tudela <ajtudela@gmail.com>
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
…d out. (ros-navigation#4959) Signed-off-by: Georg Flick <georg.flick@enway.ai> Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
ros2 topic echo /cmd_vel_smoothed, that theheader.stampis always populated by a timestamp and not zero at the end of a path or after cancelling a pathFor Maintainers: