Fixes smac planner non-circular footprint search issue#4851
Merged
SteveMacenski merged 2 commits intomainfrom Jan 14, 2025
Merged
Fixes smac planner non-circular footprint search issue#4851SteveMacenski merged 2 commits intomainfrom
SteveMacenski merged 2 commits intomainfrom
Conversation
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
This was referenced Jan 14, 2025
Member
Author
|
OG: Updated: We see no major difference in path lengths, but these updates result in lower total costs and slightly improved compute times. First is Hybrid, second is Lattice |
mergify bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
* initial prototype to resolve smac planner issue Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fix test Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> (cherry picked from commit bc9f2bc) # Conflicts: # nav2_smac_planner/src/collision_checker.cpp # nav2_smac_planner/src/node_hybrid.cpp
2 tasks
SteveMacenski
added a commit
that referenced
this pull request
Jan 14, 2025
… (#4852) * Fixes smac planner non-circular footprint search issue (#4851) * initial prototype to resolve smac planner issue Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fix test Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> (cherry picked from commit bc9f2bc) # Conflicts: # nav2_smac_planner/src/collision_checker.cpp # nav2_smac_planner/src/node_hybrid.cpp * fix mergify issue Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
kaichie
pushed a commit
to botsandus/navigation2
that referenced
this pull request
Feb 14, 2025
…n#4851) * initial prototype to resolve smac planner issue Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fix test Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
kaichie
pushed a commit
to botsandus/navigation2
that referenced
this pull request
Mar 11, 2025
…n#4851) * initial prototype to resolve smac planner issue Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fix test Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
…n#4851) * initial prototype to resolve smac planner issue Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fix test Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4808 and #4314
The optimization was added to allow non-circular robots to use their full footprint costs in the traversibility function and heuristic function formulations. However, in confined settings, it doesn't work very well and its better to collision check using the full footprint but continue to use the center point costs for the traversal function / heuristic function formulations.
Metrics outlined in #4808 (comment) show that this not only fixes the issue but also doesn't impact speeds in open areas - but faster in confined areas due to the ambiguation of inscribed costs.
TODO