Fixes smac planner non-circular footprint search issue (backport #4851)#4852
Merged
SteveMacenski merged 2 commits intojazzyfrom Jan 14, 2025
Merged
Fixes smac planner non-circular footprint search issue (backport #4851)#4852SteveMacenski merged 2 commits intojazzyfrom
SteveMacenski merged 2 commits intojazzyfrom
Conversation
* initial prototype to resolve smac planner issue Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fix test Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> (cherry picked from commit bc9f2bc) # Conflicts: # nav2_smac_planner/src/collision_checker.cpp # nav2_smac_planner/src/node_hybrid.cpp
Contributor
Author
|
Cherry-pick of bc9f2bc has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
Author
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4808 and #4314
The optimization was added to allow non-circular robots to use their full footprint costs in the traversibility function and heuristic function formulations. However, in confined settings, it doesn't work very well and its better to collision check using the full footprint but continue to use the center point costs for the traversal function / heuristic function formulations.
Metrics outlined in #4808 (comment) show that this not only fixes the issue but also doesn't impact speeds in open areas - but faster in confined areas due to the ambiguation of inscribed costs.
TODO
This is an automatic backport of pull request Fixes smac planner non-circular footprint search issue #4851 done by Mergify.