port drive on heading behavior to new gazebo#4473
port drive on heading behavior to new gazebo#4473stevedanomodolor wants to merge 2 commits intoros-navigation:mainfrom
Conversation
Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
|
This pull request is in conflict. Could you fix it @stevedanomodolor? |
…zebo Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
|
Addressed the merge conflict. I'm seeing this fail 2x in a row, I'm rerunning against from start to check, but there may be something up with this one. |
|
Yeah, this behavior seems to happen with behavior tests. I am not sure either that. I will put it on draft untill i figure out why |
|
Yeah, these aren't flaky, they're just failing most of the time :/ I suppose we could bin these under #4349 as 'fix and rewrite'? I think they all fail from the same kinds of issues of trying to do some really strange faking out of the behaviors. Similar to migrating to GZ, I think this is similarly a "figure it out once: copy paste for the rest" Please do put in draft |
|
@stevedanomodolor I'm pulling this into #4515 as I'm just rewriting the tests altogether with your base work on adding the new gazebo! |
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: