Add first example robot (rrbot as system)#37
Merged
Conversation
This was referenced Sep 11, 2020
destogl
commented
Sep 12, 2020
destogl
commented
Sep 12, 2020
This was referenced Sep 12, 2020
AndyZe
reviewed
Sep 21, 2020
* Change package names to represent the actual state. * Describe connection to the example URDFs
…/ros-controls/ros2_control_demos into add_rrbot_system_position_joints
…omment out the name of the node from the roslaunch file to avoid issue with LifecycleNode-Names. Add better robot's movement simulation.
…/ros-controls/ros2_control_demos into add_rrbot_system_position_joints
…/ros-controls/ros2_control_demos into add_rrbot_system_position_joints
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
============================================
- Coverage 100.00% 0.00% -100.00%
============================================
Files 4 1 -3
Lines 4 71 +67
============================================
- Hits 4 0 -4
- Misses 0 71 +71
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
destogl
requested review from
Karsten1987,
bmagyar,
jordan-palacios and
v-lopez
bmagyar
requested changes
Dec 4, 2020
ros2_control_demo_hardware/include/ros2_control_demo_hardware/rrbot_system_position_only.hpp
Outdated
Show resolved
Hide resolved
ros2_control_demo_hardware/include/ros2_control_demo_hardware/rrbot_system_position_only.hpp
Show resolved
Hide resolved
ros2_control_demo_hardware/include/ros2_control_demo_hardware/rrbot_system_position_only.hpp
Outdated
Show resolved
Hide resolved
ros2_control_demo_hardware/include/ros2_control_demo_hardware/rrbot_system_position_only.hpp
Outdated
Show resolved
Hide resolved
jordan-palacios
approved these changes
Dec 4, 2020
Member
jordan-palacios
left a comment
jordan-palacios
left a comment
There was a problem hiding this comment.
Barring @bmagyar comments, LGTM.
Member
|
@destogl I'm happy to update these components (let's merge soon) once ros-controls/ros2_control#258 is merged. I'm happy to merge this now |
…rrbot_system_position_only.hpp Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
This was referenced Dec 5, 2020
bmagyar
approved these changes
Dec 5, 2020
Member
bmagyar
left a comment
bmagyar
left a comment
There was a problem hiding this comment.
Tested with latest master of framework and controllers, nice work!
Also tested all commands in the readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some TODOs: