Remove empty argument on INSTANTIATE_TEST_CASE_P for Rolling#390
Merged
destogl merged 1 commit intoros-controls:masterfrom Apr 23, 2021
Merged
Conversation
destogl
approved these changes
Apr 23, 2021
Member
destogl
left a comment
destogl
left a comment
There was a problem hiding this comment.
This looks fine. It is currently not used functionality, but probably compiles.
Member
|
Merging because it does not affects anything relevant. |
Contributor
Author
|
Thanks! |
Contributor
|
this PR breaks the compilation on OSX. |
Contributor
|
I am going to revert this. If there're any breaking changes for rolling, we should branch off. As for now, master only targets Foxy. |
Karsten1987
added a commit
that referenced
this pull request
Apr 23, 2021
This reverts commit 55bd249.
Karsten1987
added a commit
that referenced
this pull request
Apr 24, 2021
Member
|
@Karsten1987 is it feasible to add OSX build into C? Is this supported by GH-Actions? |
destogl
added a commit
to b-robotized-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
variables in JTC to not clutter other PR with them. fixes of updating parameters on renewed configuration of JTC that were missed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not compile with the errors @tylerjw mentioned in #389, since INSTANTIATE_TEST_CASE_P no longer accepts empty arguments. This PR remove empty argument on INSTANTIATE_TEST_CASE_P to compile ros2_control on rolling