Merged
Conversation
bmagyar
reviewed
Dec 9, 2020
destogl
requested changes
Dec 10, 2020
Member
destogl
left a comment
destogl
left a comment
There was a problem hiding this comment.
I would not change ControllerInterface so massively, but add an additional layer...
controller_interface/include/controller_interface/controller_interface.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/controller_interface/controller_interface.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/controller_interface/controller_interface.hpp
Show resolved
Hide resolved
bmagyar
approved these changes
Dec 11, 2020
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
v-lopez
force-pushed
the
remove-lifecycle-node
branch
from
876fd72 to
aaabb42
Compare
Member
|
Thanks guys! I'll be merging this now and review the controller side. |
destogl
added a commit
to b-robotized-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
ControllerInterface::get_lifecycle_nodetoget_nodeactivate,configureand similar methods toControllerInterfaceto emulate the API thatLifecycleNodeprovided