Remove todo resource checking#264
Merged
bmagyar merged 1 commit intoros-controls:masterfrom Dec 19, 2020
Merged
Conversation
Member
|
@bmagyar can you rebase this to make a review cleaner? |
bmagyar
force-pushed
the
remove-todo-resource-checking
branch
from
876fd72 to
09001f3
Compare
Member
|
@destogl done |
bmagyar
approved these changes
Dec 16, 2020
Member
bmagyar
left a comment
bmagyar
left a comment
There was a problem hiding this comment.
This is fine with me, although some of the methods may be still useful but we don't have robot_hw to tie them to anymore
Contributor
Author
|
Yes, for part of the funcionality I added this: #262 |
Member
|
Removing dead code in 3, 2, 1... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes on top of #261