Add some default functionality to SystemHardwareInterface#180
Closed
bmagyar wants to merge 1 commit intoros-controls:masterfrom
Closed
Add some default functionality to SystemHardwareInterface#180bmagyar wants to merge 1 commit intoros-controls:masterfrom
bmagyar wants to merge 1 commit intoros-controls:masterfrom
Conversation
Contributor
|
as stated in #171 I don't think there should be a default implementation in these interfaces. I vote for having them pure interfaces only. |
destogl
approved these changes
Oct 7, 2020
Member
There was a problem hiding this comment.
I agree with all.
@Karsten1987 this doesn't go with the idea to keep the hardware_interface package only filed with interfaces. Do you have idea about better place for this default functionality?
Otherwise, I propose to just merge this fast.
@bmagyar Would you provide in the follow-up the same for SensorHardwareInterface and ActuatorHardwareInterface. Also, the tests should be updated then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of creating yet another layer of abstraction, this PR merges some of the functionality proposed here into the base class. Since this is fairly trivial functionality, we may want to consider doing the same for the rest of the components.