Conversation
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
|
I've added a set of function overloads in 7ac53d5 which lets the user add hardware components which are not declared in the URDF. |
controller_manager/include/controller_manager/loaned_command_interface.hpp
Outdated
Show resolved
Hide resolved
controller_manager/include/controller_manager/loaned_command_interface.hpp
Outdated
Show resolved
Hide resolved
controller_manager/include/controller_manager/loaned_command_interface.hpp
Show resolved
Hide resolved
* move resource manager to hardware interface Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * include functional for std::function Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
|
I hope to have addressed all review comments @bmagyar |
|
@destogl please go ahead and open follow-up tickets or continue to comment on this PR in case you have outstanding comments. |
|
I don't have major comments, just need a few clarifications. For example, I am missing unclaiming of the command_interfaces. |
|
The "unclaiming" happens implicit in the destructor of the ros2_control/hardware_interface/src/resource_manager.cpp Lines 212 to 216 in 925f5f3 The destructor has a support for a custom callback upon destruction, which is set here: ros2_control/hardware_interface/src/resource_manager.cpp Lines 267 to 269 in 925f5f3 |
Part four of #164
currently sits on top of #207