move resource manager to hardware interface#226
Merged
Karsten1987 merged 2 commits intoresource_loaningfrom Nov 9, 2020
Merged
move resource manager to hardware interface#226Karsten1987 merged 2 commits intoresource_loaningfrom
Karsten1987 merged 2 commits intoresource_loaningfrom
Conversation
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Member
|
If you can get this to compile we could merge it into #224 |
Member
|
@Karsten1987 the build should be fixed |
Codecov Report
@@ Coverage Diff @@
## resource_loaning #226 +/- ##
===================================================
Coverage ? 34.64%
===================================================
Files ? 52
Lines ? 2982
Branches ? 1854
===================================================
Hits ? 1033
Misses ? 314
Partials ? 1635
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
|
I'll merge this into #224 as this will make sense in order to address your outstanding comments on that PR. |
Karsten1987
added a commit
that referenced
this pull request
Nov 11, 2020
* introducing handles Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * component interfaces & tests Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * linters Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * import resource manager Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * correct year Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * import handles from loaded components Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * wip / debug Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * parse components Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * changes after rebase Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * component parser as shared library Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * validate urdf configuratin Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * documentation Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * remove default constructor Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * resource loaning Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * loan state interface Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * import externally declared components Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * move resource manager to hardware interface (#226) * move resource manager to hardware interface Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * include functional for std::function Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> * address review comments Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sits on top of #224
given the discussion in #216, I've moved the resource manager to a public API which essentially gets passed in to the controller manager instead of the robot hardware instance.
I've further had to move the resource manager into the hardware interface package, as I had circular dependency between controller manager and controller interface if not.
This PR is not changing any code, simply moving files around.