Closed
Conversation
Karsten1987
commented
Oct 8, 2020
| // hardware_class_type has to match class name in plugin xml description | ||
| // TODO(karsten1987) extract package from hardware_class_type | ||
| // e.g.: <package_vendor>/<system_type> | ||
| // TODO(dstoegl) why is it class_type here and "hardware_class_type" in hardware_info? |
Karsten1987
force-pushed
the
resource_loaning
branch
from
085fd57 to
09dfe09
Compare
bmagyar
reviewed
Oct 9, 2020
.github/workflows/ci.yml
Outdated
| env: | ||
| - {ROS_DISTRO: foxy, ROS_REPO: main} | ||
| - {ROS_DISTRO: foxy, ROS_REPO: testing} | ||
| - {ROS_DISTRO: foxy, ROS_REPO: main} |
Contributor
Author
There was a problem hiding this comment.
is that a GH displaying thing? I can't seem to find the change.
Karsten1987
force-pushed
the
resource_loaning
branch
from
ec8cdb8 to
64ceb50
Compare
Contributor
Author
|
something's up with this PR. GH doesn't seem to recognize the last commit on top: 582be33 |
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Karsten1987
force-pushed
the
resource_loaning
branch
from
582be33 to
0a33718
Compare
destogl
pushed a commit
to b-robotized-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #174 and sits on top of #171