Skip to content

Conversation

@christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Nov 24, 2024

Needs ros-controls/ros2_control_ci#374

I had to make a workaround for RSL, because colcon+MSVC does not consider the CMakePresets file.

Needs upstream changes:

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.38%. Comparing base (a422c48) to head (3ffa9c7).

Additional details and impacted files
@@             Coverage Diff              @@
##           ros2-master     #238   +/-   ##
============================================
  Coverage        78.38%   78.38%           
============================================
  Files               30       30           
  Lines             1888     1888           
  Branches           114      114           
============================================
  Hits              1480     1480           
  Misses             338      338           
  Partials            70       70           
Flag Coverage Δ
unittests 78.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Mar 31, 2025
@mergify
Copy link

mergify bot commented Mar 31, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@github-actions github-actions bot removed the stale label Apr 1, 2025
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label May 16, 2025
@github-actions github-actions bot removed the stale label Jun 16, 2025
@christophfroehlich christophfroehlich marked this pull request as ready for review June 23, 2025 07:13
@christophfroehlich christophfroehlich merged commit b2b3425 into ros2-master Jun 23, 2025
21 of 23 checks passed
@christophfroehlich christophfroehlich deleted the ci/windows branch June 23, 2025 11:42
@christophfroehlich christophfroehlich added backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. labels Jun 23, 2025
mergify bot pushed a commit that referenced this pull request Jun 23, 2025
(cherry picked from commit b2b3425)
@mergify mergify bot mentioned this pull request Jun 23, 2025
1 task
mergify bot pushed a commit that referenced this pull request Jun 23, 2025
(cherry picked from commit b2b3425)
@mergify mergify bot mentioned this pull request Jun 23, 2025
1 task
christophfroehlich pushed a commit that referenced this pull request Jun 23, 2025
christophfroehlich pushed a commit that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants