Refactor Egg Moves

[Bassoonian]

Refactors Egg moves so they're not a giant array with weird offsets anymore but rather structured lists like the teachable learnsets. All functionality is otherwise kept as similar to the original as possible, so this should not cause any real issues with feature branches.

Issue(s) that this PR fixes

Fixes #3653

Discord contact info

bassoonian

[GraionDilach]

Why's this PRed from the setteratype branch?

[Bassoonian]

Why's this PRed from the setteratype branch?

Because I suck at git. Functionally it doesn't make a difference though since the commit from that branch was already merged into upcoming before

[GraionDilach]

It just makes 0441667 confusing somewhat, so prolly that comment should be rebased out.

On a more relevant note - should this include setting the basic egg move arrays for the evolved mons wrt #4479?

[Bassoonian]

On a more relevant note - should this include setting the basic egg move arrays for the evolved mons wrt #4479?

Since that discussion is still ongoing and we should limit the scope, I think they should remain separate PRs.

[AsparagusEduardo]

It just makes 0441667 confusing somewhat, so prolly that comment should be rebased out.

Agreed. @Bassoonian, please rebase your changes to the latest upcoming to avoid these stray commits and muddle reviews.

[AsparagusEduardo]

Also, can you add the migration script for this refactor to the migration scripts folder?

[Bassoonian]

Superseded by #4534