Egg Move Refactor

[Bassoonian]

Supersedes #4488 with a clean git history and a migration script

Description

Refactors Egg moves so they're not a giant array with weird offsets anymore but rather structured lists like the teachable learnsets. All functionality is otherwise kept as similar to the original as possible, so this should not cause any real issues with feature branches.

egg_moves.h as well as the gBaseStats files are exactly as they would be when running the migration script on the current version of upcoming.

Issue(s) that this PR fixes

Fixes #3653

Discord contact info

bassoonian

[AlexOn1ine]

Tried running the script in my repo and got this:

egg_move_refactor.py:18: SyntaxWarning: invalid escape sequence '\('
  for mon in re.findall("egg_moves\((.*),", data):
egg_move_refactor.py:26: SyntaxWarning: invalid escape sequence '\('
  data = re.sub("    egg_moves\(%s," % mon, "static const u16 s%sEggMoveLearnset[] = {" % monname, data)
egg_move_refactor.py:28: SyntaxWarning: invalid escape sequence '\)'
  data = re.sub("\),\n", ",\n        MOVE_UNAVAILABLE,\n};\n", data) # add terminator to each old macro
egg_move_refactor.py:42: SyntaxWarning: invalid escape sequence '\.'
  data = re.sub("\.teachableLearnset = s%sTeachableLearnset,\n" % mon, ".teachableLearnset = s%sTeachableLearnset,\n        .eggMoveLearnset = s%sEggMoveLearnset,\n" % (mon, mon), data)
egg_move_refactor.py:44: SyntaxWarning: invalid escape sequence '\.'
  macrocheck = re.findall("\.teachableLearnset = s%sTeachableLearnset,( *)\\\\" % mon, data)
egg_move_refactor.py:46: SyntaxWarning: invalid escape sequence '\.'
  data = re.sub("\.teachableLearnset = s%sTeachableLearnset,%s\\\\" % (mon, macrocheck[0]), ".teachableLearnset = s%sTeachableLearnset,%s\\\\\n        .eggMoveLearnset = s%sEggMoveLearnset,%s\\\\" % (mon, macrocheck[0], mon, " " * (len(macrocheck[0]) + 4)), data)

Edit: it seems like the script did it's thing though

[Bassoonian]

Tried running the script in my repo and got this:

egg_move_refactor.py:18: SyntaxWarning: invalid escape sequence '\('
  for mon in re.findall("egg_moves\((.*),", data):
egg_move_refactor.py:26: SyntaxWarning: invalid escape sequence '\('
  data = re.sub("    egg_moves\(%s," % mon, "static const u16 s%sEggMoveLearnset[] = {" % monname, data)
egg_move_refactor.py:28: SyntaxWarning: invalid escape sequence '\)'
  data = re.sub("\),\n", ",\n        MOVE_UNAVAILABLE,\n};\n", data) # add terminator to each old macro
egg_move_refactor.py:42: SyntaxWarning: invalid escape sequence '\.'
  data = re.sub("\.teachableLearnset = s%sTeachableLearnset,\n" % mon, ".teachableLearnset = s%sTeachableLearnset,\n        .eggMoveLearnset = s%sEggMoveLearnset,\n" % (mon, mon), data)
egg_move_refactor.py:44: SyntaxWarning: invalid escape sequence '\.'
  macrocheck = re.findall("\.teachableLearnset = s%sTeachableLearnset,( *)\\\\" % mon, data)
egg_move_refactor.py:46: SyntaxWarning: invalid escape sequence '\.'
  data = re.sub("\.teachableLearnset = s%sTeachableLearnset,%s\\\\" % (mon, macrocheck[0]), ".teachableLearnset = s%sTeachableLearnset,%s\\\\\n        .eggMoveLearnset = s%sEggMoveLearnset,%s\\\\" % (mon, macrocheck[0], mon, " " * (len(macrocheck[0]) + 4)), data)

Edit: it seems like the script did it's thing though

Ah, this is me not making it raw strings again. I'll try to fix it