Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix daycare move transferring between evolved mons and allow sharing moves between different forms of the same species #4479

Merged
merged 9 commits into from
Jun 7, 2024
Merged

Fix daycare move transferring between evolved mons and allow sharing moves between different forms of the same species #4479

merged 9 commits into from
Jun 7, 2024

Conversation

Sneed69
Copy link

@Sneed69 Sneed69 commented May 2, 2024

Issue(s) that this PR fixes

  1. Evolved mons could not copy moves as they do not have their own egg move table.
  2. Different forms of the same species could not copy egg moves from each other.

Alternatively the first issue could be fixed by assigning egg moves to evolved mons.

Discord contact info

duke5614

@Sneed69
Fix daycare move transferring between evolved mons
09e3e75 
Also allow sharing moves between different forms
@Sneed69 Sneed69 marked this pull request as draft May 2, 2024 14:10
@Sneed69 Sneed69 marked this pull request as ready for review May 2, 2024 14:20
@Sneed69 Sneed69 marked this pull request as draft May 2, 2024 14:30
@Sneed69 Sneed69 marked this pull request as ready for review May 2, 2024 14:58
@Sneed69
Copy link
Author

Sneed69 commented May 2, 2024 •
edited
Loading

Additionally:

  • Converts a preproc check to run time. (Compile time on modern?)
  • Renames GetEggMovesSpecies to GetEggMovesBySpecies

Bassoonian
Bassoonian reviewed May 2, 2024
View reviewed changes
src/daycare.c Outdated Show resolved Hide resolved
src/daycare.c Outdated Show resolved Hide resolved
@GraionDilach GraionDilach mentioned this pull request May 4, 2024
Closed
@Sneed69
Copy link
Author

Sneed69 commented May 30, 2024

Ready for re-review

Bassoonian
Bassoonian reviewed Jun 7, 2024
View reviewed changes
src/daycare.c Outdated Show resolved Hide resolved
@Bassoonian Bassoonian merged commit 2cc2dc0 into rh-hideout:master Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bassoonian Bassoonian Bassoonian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sneed69 @Bassoonian