Egg Moves need a refactor

[Bassoonian]

Description

See #3562

Version

upcoming (Edge)

Upcoming Version

No response

Discord contact info

No response

[cfmnephrite]

How would you do this without adding a prevo field to SpeciesInfo?

[mrgriffin]

How would you do this without adding a prevo field to SpeciesInfo?

I think we could at least split gEggMoves up into separate arrays, and also write the individual arrays as literals in the species_info header files (similar to evolutions etc etc)?

gEggMoves is absolutely horrifying, a single array that intermingles species IDs (offset by 20000) with move IDs.

[cfmnephrite]

How would you do this without adding a prevo field to SpeciesInfo?

I think we could at least split gEggMoves up into separate arrays, and also write the individual arrays as literals in the species_info header files (similar to evolutions etc etc)?

gEggMoves is absolutely horrifying, a single array that intermingles species IDs (offset by 20000) with move IDs.

Sorry, I was half asleep when I wrote that comment and I realise it makes no sense. I took adding egg moves as a compound literal as a given. I was trying to ask if we would also add the prevo field as part of an egg moves reform - for an easy way to retrieve them - or stick to using the old function for calculating prevos by iterating over literally every species. You know, since if we're iterating over a stupidly huge array anyway then we haven't really made that much of a change - except make species_info.h even more unwieldy :P

[AsparagusEduardo]

#4534